Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark unintentionally deleted on normal usage #16658

Open
juanmiag opened this issue Jun 28, 2021 · 1 comment
Open

Bookmark unintentionally deleted on normal usage #16658

juanmiag opened this issue Jun 28, 2021 · 1 comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/bookmarks OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. repros-on-chrome

Comments

@juanmiag
Copy link

Description

Pressing escape after clicking on the bookmark button (on the left of search bar) of a bookmarked site makes the bookmark to be deleted. I think that in this situation, when we press escape, the bookmark popup info should just close, but no delete the actual bookmark. We could end up with bookmarks being deleted without knowing it.

Steps to Reproduce

  1. Go to any website.
  2. Add site to bookmarks (ctrl+d or press bookmark icon).
  3. Ensure the bookmark is saved and the popup for adding it its closed (bookmark icon shows marked or "filled").
  4. Press bookmark icon (or ctrl+d) and bookmark popup shows up.
  5. Press escape to close that popup and bookmarks get deleted

Actual result:

Bookmark gets deleted.

Expected result:

Popup should close and bookmark keep saved.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.26.67 Chromium: 91.0.4472.114 (Build oficial) (64 bits)
Revisión 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}

Version/Channel Information:

Not tested.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No.
  • Does the issue resolve itself when disabling Brave Rewards?
    No.
  • Is the issue reproducible on the latest version of Chrome?
    Yes.

Greetings

@rebron rebron added repros-on-chrome feature/bookmarks needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Jul 6, 2021
@lazymonkey2
Copy link

please fix this one... I keep erasing bookmarks unintentionally.

@rebron rebron removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Aug 21, 2021
@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix labels Sep 28, 2021
@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to Needs Info in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/bookmarks OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. repros-on-chrome
Projects
Status: Needs Info
Development

No branches or pull requests

3 participants