Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page doesn't reload if BR panel or site banner is open #1662

Closed
srirambv opened this issue Oct 17, 2018 · 6 comments
Closed

Page doesn't reload if BR panel or site banner is open #1662

srirambv opened this issue Oct 17, 2018 · 6 comments
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@srirambv
Copy link
Contributor

Description

Page doesn't reload if BR panel or site banner is open

Steps to Reproduce

  1. Enable rewards and add funds
  2. Visit a site and open BR panel/send tip site banner
  3. Try reloading using keyboard shortcut (Ctrl+R), page doesn't reload until site banner/BR panel is closed

Actual result:

Page doesn't reload if BR panel or site banner is open

Expected result:

Panel/banner should not interfere with page reload and should ideally be closed when reload is triggered

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv srirambv added this to the 1.x Backlog milestone Oct 17, 2018
@btlechowski
Copy link

Reproduced on Windows 7 x64

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7 x64

@NejcZdovc
Copy link
Contributor

@srirambv that is not the case. I think this is correct behaviour

cc @davidtemkin

@srirambv
Copy link
Contributor Author

Not so sure about it. i think page reload shouldn't be restricted just because the panel/banner is being displayed. As a matter of fact i see even if shields is open you can't reload the page. This is not the case on muon. Even with shields being shown you can reload the page. Either the panel/shields/banner should be closed on F5/reload or retain them but independently reload the page(muon behaviour on shields)

cc: @kjozwiak @bbondy

@NejcZdovc
Copy link
Contributor

I think this is native behaviour for extensions in chromium

@kjozwiak
Copy link
Member

Working on macOS for both Chrome & Brave. Seems related to Win/Linux.

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 19, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@NejcZdovc
Copy link
Contributor

@srirambv still a problem?

@Miyayes Miyayes added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Oct 8, 2021
@Miyayes Miyayes closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

7 participants