Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Search feedback window lags, can be resized way too much, and is not centered #16616

Open
rebron opened this issue Jun 25, 2021 · 1 comment
Labels
Brave Search design A design change, especially one which needs input from the design team OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 25, 2021

Description

Just a couple of things that can improve the UX when interacting with Brave Search's feedback window.

  1. There is a delay when choosing different feedback options.
  2. The textbox can be resized so much that the "Submit" option and the possibility to resize disappear, and users have to re-open the feedback window to fix it.
  3. The feedback window should be positioned better, should be centered.

Steps to Reproduce

  1. Open the feedback window after using Brave Search.
  2. Click the different options.
  3. Check how much the window can be resized.

Actual result:

CYSwT1amLh

Expected result:

  1. There shouldn't be a delay when selecting different feedback options.
  2. Users shouldn't be able to resize the textbox so much that the feedback window becomes unusable.
  3. The feedback window should be centered.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.26.67 Chromium: 91.0.4472.114 (Official Build) (64-bit)
Revision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS Windows 7 Service Pack 1 (Build 7601)
JavaScript V8 9.1.269.36
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36
Command Line "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --no-pings --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=LegacyTLSEnforced,WebUIDarkMode,PrefetchPrivacyChanges,PasswordImport,ReducedReferrerGranularity,AutoupgradeMixedContent,WinrtGeolocationImplementation,SafetyTip --disable-features=HandwritingRecognitionWebPlatformApiFinch,FlocIdComputedEventLogging,TextFragmentAnchor,EnableProfilePickerOnStartup,AutofillEnableAccountWalletStorage,FledgeInterestGroupAPI,InterestCohortFeaturePolicy,FledgeInterestGroups,TrustTokens,DirectSockets,IdleDetection,SubresourceWebBundles,NetworkTimeServiceQuerying,LangClientHintHeader,SignedExchangePrefetchCacheForNavigations,FederatedLearningOfCohorts,AutofillServerCommunication,LiveCaption,WebOTP,NotificationTriggers,HandwritingRecognitionWebPlatformApi,SignedExchangeSubresourcePrefetch,InterestCohortAPIOriginTrial,FirstPartySets --flag-switches-begin --enable-features=LegacyTLSEnforced,WebUIDarkMode,PrefetchPrivacyChanges,PasswordImport,ReducedReferrerGranularity,AutoupgradeMixedContent,WinrtGeolocationImplementation,SafetyTip,EphemeralStorage --flag-switches-end
Executable Path C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
Profile Path C:\Users\User\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default
Variations EphemeralStorageStudy:EnabledPermissionLifetimeReleaseStudy:Enabled

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @Tonev Originally https://github.com/brave/brave-browser/issues/16586 but I made a mistake and transferred to a different repo. Sorry about that. Thanks for the report.
@Tonev
Copy link
Contributor

Tonev commented Jun 25, 2021

@rebron

Thank you for restoring my report 👍

@rebron rebron changed the title [Brave Search] The feedback window lags, can be resized way too much, and is not centered Brave Search feedback window lags, can be resized way too much, and is not centered Oct 19, 2021
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". design A design change, especially one which needs input from the design team labels Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Brave Search design A design change, especially one which needs input from the design team OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

2 participants