You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
New Choose a wallet service modal should have Uphold privacy-policy link
Credit goes to @LaurenWags who pointed this out to me - I should've caught it when verifying #16178
Steps to Reproduce
launch Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
click on the BAT icon
click on Start using Rewards
click Skip for now
click Done
click on Verify Wallet (brave://rewards/#verify)
click Continue >
click on Uphold
look at the resulting change to the modal
Actual result:
The modal correctly adds the minimum-balance-Uphold message and Continue to login link, but neglects adding the Uphold privacy-policy link in the bottom Note: paragraph.
@codybanxs @Miyayes We may have discussed this previously, but with the current design we won't be able to display a link to the wallet provider's privacy policy, since the user has not yet selected a provider. If the user has the minimum BAT amount required by the provider, then they'll be taken directly to the provider's login screen when they press the button.
Description
New Choose a wallet service modal should have Uphold privacy-policy link
Credit goes to @LaurenWags who pointed this out to me - I should've caught it when verifying #16178
Steps to Reproduce
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
Start using Rewards
Skip for now
Done
Verify Wallet
(brave://rewards/#verify
)Continue >
Uphold
Actual result:
The modal correctly adds the minimum-balance-Uphold message and
Continue to login
link, but neglects adding the Uphold privacy-policy link in the bottomNote:
paragraph.Expected result:
Per the mockup in the security/privacy review (https://github.com/brave/security/issues/473#issuecomment-856294892), the Choose a wallet service model should have an Uphold privacy policy link (
https://uphold.com/en/legal/privacy-policy
?)Reproduces how often:
100%
Brave version (brave://version info)
/cc @codybanxs @Miyayes @zenparsing
The text was updated successfully, but these errors were encountered: