Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show badge on built-in ipfs-webui #16340

Closed
spylogsster opened this issue Jun 10, 2021 · 1 comment · Fixed by brave/brave-core#9077
Closed

Do not show badge on built-in ipfs-webui #16340

spylogsster opened this issue Jun 10, 2021 · 1 comment · Fixed by brave/brave-core#9077
Assignees
@spylogsster
Labels
OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.27.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Jun 10, 2021 •
edited
Loading

initial task #15718

  • Enable local node and redirect IPFS resources to configured gateway
  • go to brave://ipfs -> My Node -> see IPFS badge in address bar
  • Click badge -> url is opened, navigation to subpages will be failed

Expected result

  • the IPFS badge is not shown for build-in ipfs-webui

Test plan

  • Enable local node and redirect IPFS resources to configured gateway
  • go to brave://ipfs -> My Node
  • The IPFS badge is not visible for api pages
@spylogsster spylogsster self-assigned this Jun 10, 2021
@spylogsster spylogsster changed the title Do not show badge for API pages Do not show badge on built-in ipfs-webui Jun 10, 2021
@spylogsster spylogsster mentioned this issue Jun 10, 2021
Merged
24 tasks
@spylogsster spylogsster added this to the 1.27.x - Nightly milestone Jun 12, 2021
@stephendonner
Copy link

Verified PASSED using the inline testplan with build

Brave 1.27.61 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. loaded ipns://brantly.eth
  3. clicked Use a local node
  4. went to brave://settings/ipfs and toggled Redirect IPFS resources to the configured IPFS gateway to On
  5. loaded brave://ipfs-internals and clicked on My Node
  6. confirmed there was no Open using IPFS badge in the URL bar for this internal API page
example example example
Screen Shot 2021-06-14 at 11 00 02 AM Screen Shot 2021-06-14 at 11 03 33 AM Screen Shot 2021-06-14 at 11 00 10 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging a pull request may close this issue.

Do not show badge on built-in ipfs-webui brave/brave-core
3 participants
@stephendonner @spylogsster @LaurenWags