Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL for Japan NTP Page #16130

Closed
anthonypkeane opened this issue May 28, 2021 · 3 comments · Fixed by brave/brave-core#8969
Closed

Update URL for Japan NTP Page #16130

anthonypkeane opened this issue May 28, 2021 · 3 comments · Fixed by brave/brave-core#8969

Comments

@anthonypkeane
Copy link

Description

For ticket #15526
Please update the URL from https://brave.com/ja/users-bitflyer/ to https://brave.com/ja/desktop-ntp-tutorial

cc @Miyayes

@soham4abc
Copy link

@rebron @anthonypkeane Please review I have made a PR related to this issue. Please!

@rebron
Copy link
Collaborator

rebron commented Jun 9, 2021

@anthonypkeane When is this page https://brave.com/ja/desktop-ntp-tutorial going live?

@stephendonner
Copy link

stephendonner commented Jun 22, 2021

Verified PASSED using

Brave 1.26.73 Chromium: 91.0.4472.124 (Official Build) (x86_64)
変更履歴 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS macOS バージョン11.4(ビルド20F71)

Steps:

  1. set language + region in macOS to Japanese/Japan, respectively
  2. new profile in Brave
  3. launched Brave
  4. looked at 2nd opened (but not focused) tab

Confirmed the URL in the 2nd tab is now https://brave.com/ja/desktop-ntp-tutorial/

スクリーンショット 2021-06-21 17 25 37


Verified passed with

Brave	1.26.73 Chromium: 91.0.4472.124 (Official Build) (64 ビット)
変更履歴	7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS	Linux

Confirmed on a clean profile that the 2nd tab (inactive) opened for Japan locale/language has the URL for https://brave.com/ja/desktop-ntp-tutorial/.

Linux Japan NTP Tutorial

Also checked that on upgrade from 1.26.67 another tab with this URL is not opened.


Verification passed on

Brave	1.26.73 Chromium: 91.0.4472.124 (Official Build) (64 ビット)
変更履歴	7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS	Windows 10 OS Version 1809 (Build 17763.1637)

Confirmed the URL in the 2nd tab is now https://brave.com/ja/desktop-ntp-tutorial/
image

Also checked that on upgrade from 1.26.67 another tab with this URL is not opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment