Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News should require explicit opt-in #15926

Closed
petemill opened this issue May 18, 2021 · 1 comment · Fixed by brave/brave-core#8830
Closed

Brave News should require explicit opt-in #15926

petemill opened this issue May 18, 2021 · 1 comment · Fixed by brave/brave-core#8830

Comments

@petemill
Copy link
Member

Previously it was deemed ok to not require an explicit opt-in for Brave News' remote network fetch because:

  1. It waited for user interaction with the feature before making any network requests. In other words, it did not request data for the feature if the user did not actively use it, whether it was already on for that user's region or not.
  2. The network requests use Brave's Private CDN, meaning no identity or behaviorally-identifiable information is transmitted. Every user requests the same feed, and the specific article images are all padded to be the same size.

However, in the interests of caution we want to require the users to explicitly opt-in to the feature, including the privacy policy, before making any network requests.

@petemill petemill self-assigned this May 18, 2021
@bsclifton bsclifton added this to the 1.26.x - Nightly milestone May 19, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 27, 2021
@stephendonner
Copy link

stephendonner commented May 27, 2021

Verified PASSED using

Brave 1.26.43 Chromium: 91.0.4472.77 (Official Build) beta (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Migration - have previously used Brave Today in 1.25.68

Steps:

  1. new profile, launch 1.25.68
  2. open a new-tab page
  3. click on Customize
  4. click on Brave Today
  5. ensure Show Brave Today is defaulted to On
  6. scroll down and view a few sheets worth of Brave Today articles
  7. quit Brave
  8. save profile off
  9. install 1.26.43
  10. rename original profile to Brave-Browser-Beta
  11. launch 1.26.43
  12. open a new-tab page
  13. scroll down
  14. confirm you get shown a panel with Show Brave News and No thanks
  15. click on No thanks
  16. confirm the panel is dismissed, and Brave News doesn't display
  17. click on Customize
  18. click on Brave News
  19. click the toggle for Show Brave News to On
  20. click the X to dismiss the dialog
  21. scroll down
  22. confirm you see the panel again
  23. this time, click on Show Brave News
  24. confirm Brave News' content now displays
example example example example example example
Screen Shot 2021-05-27 at 2 41 20 PM Screen Shot 2021-05-27 at 2 41 27 PM Screen Shot 2021-05-27 at 2 42 57 PM Screen Shot 2021-05-27 at 2 43 06 PM Screen Shot 2021-05-27 at 2 43 13 PM Screen Shot 2021-05-27 at 2 43 28 PM

Migration - have NOT previously used Brave Today in 1.25.68

Steps:

  1. new profile, launch 1.25.68
  2. open a new-tab page
  3. click on Customize
  4. click on Brave Today
  5. ensure Show Brave Today is defaulted to On
  6. do NOT scroll down
  7. quit Brave
  8. save profile off
  9. install 1.26.43
  10. rename original profile to Brave-Browser-Beta
  11. launch 1.26.43
  12. open a new-tab page
  13. scroll down
  14. confirm you get shown a panel with Show Brave News and No thanks
  15. click on No thanks
  16. confirm the panel is dismissed, and Brave News doesn't display
  17. click on Customize
  18. click on Brave News
  19. click the toggle for Show Brave News to On
  20. click the X to dismiss the dialog
  21. scroll down
  22. confirm you see the panel again
  23. this time, click on Show Brave News
  24. confirm Brave News' content now displays
example example example example example example
Screen Shot 2021-05-27 at 2 53 49 PM Screen Shot 2021-05-27 at 2 54 33 PM
Screen Shot 2021-05-27 at 2 54 54 PM Screen Shot 2021-05-27 at 2 55 01 PM
Screen Shot 2021-05-27 at 2 55 21 PM Screen Shot 2021-05-27 at 2 55 34 PM

New profile - 1.26.43

  1. new profile, launch 1.26.43
  2. open a new-tab page
  3. click on Customize
  4. click on Brave Today
  5. ensure Show Brave Today is defaulted to On
  6. scroll down
  7. confirm you get shown a panel with Show Brave News and No thanks
  8. click on No thanks
  9. confirm the panel is dismissed, and Brave News doesn't display
  10. click on Customize
  11. click on Brave News
  12. click the toggle for Show Brave News to On
  13. click the X to dismiss the dialog
  14. scroll down
  15. confirm you see the panel again
  16. this time, click on Show Brave News
  17. confirm Brave News' content now displays
example example example example example
Screen Shot 2021-05-27 at 3 01 25 PM Screen Shot 2021-05-27 at 3 01 30 PM Screen Shot 2021-05-27 at 3 01 37 PM Screen Shot 2021-05-27 at 3 01 57 PM Screen Shot 2021-05-27 at 3 08 01 PM

Filed #15977 for the Brave News source list showing 0 in the Customize Dashboard's Brave News panel, when not-yet opted in.


Verification passed on

<!--StartFragment-->
Brave | 1.26.47 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

New profile - `1.26.47`
example example example example example
image image image image image
- Encountered https://github.com//issues/15977
Upgrade profile - Not used Brave News in `1.25.x`
1.25.x 1.26.x 1.26.x 1.26.x 1.26.x 1.26.x
image image image image image image
Upgrade profile - used Brave News in `1.25.x`
1.25.x 1.25.x 1.26.x 1.26.x 1.26.x
image image image image image

Verification passed on

Brave 1.26.45 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS
Clean profile
image image image
Upgrade profile - Not used Brave News in `1.25.x`
image image image
Upgrade profile - used Brave News in `1.25.x`
image image image image

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 27, 2021
@rebron rebron changed the title Brave News should require hard opt-in Brave News should require explicit opt-in Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment