-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave News should require explicit opt-in #15926
Labels
Milestone
Comments
petemill
added
feature/new-tab
QA/Yes
release-notes/include
OS/Desktop
feature/brave-news
formerly brave-today
labels
May 18, 2021
24 tasks
stephendonner
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
May 27, 2021
Verified
Migration - have previously used Brave Today in
|
example | example | example | example | example | example |
---|---|---|---|---|---|
Migration - have NOT previously used Brave Today in 1.25.68
Steps:
- new profile, launch
1.25.68
- open a new-tab page
- click on
Customize
- click on
Brave Today
- ensure
Show Brave Today
is defaulted toOn
- do NOT scroll down
- quit Brave
- save profile off
- install
1.26.43
- rename original profile to Brave-Browser-Beta
- launch
1.26.43
- open a new-tab page
- scroll down
- confirm you get shown a panel with
Show Brave News
andNo thanks
- click on
No thanks
- confirm the panel is dismissed, and Brave News doesn't display
- click on
Customize
- click on
Brave News
- click the toggle for
Show Brave News
toOn
- click the
X
to dismiss the dialog - scroll down
- confirm you see the panel again
- this time, click on
Show Brave News
- confirm Brave News' content now displays
example | example | example | example | example | example |
---|---|---|---|---|---|
New profile - 1.26.43
- new profile, launch
1.26.43
- open a new-tab page
- click on
Customize
- click on
Brave Today
- ensure
Show Brave Today
is defaulted toOn
- scroll down
- confirm you get shown a panel with
Show Brave News
andNo thanks
- click on
No thanks
- confirm the panel is dismissed, and Brave News doesn't display
- click on
Customize
- click on
Brave News
- click the toggle for
Show Brave News
toOn
- click the X to dismiss the dialog
- scroll down
- confirm you see the panel again
- this time, click on
Show Brave News
- confirm Brave News' content now displays
example | example | example | example | example |
---|---|---|---|---|
Filed #15977 for the Brave News source list showing 0
in the Customize Dashboard
's Brave News
panel, when not-yet opted in.
Verification passed on
<!--StartFragment-->
Brave | 1.26.47 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows 10 OS Version 2004 (Build 19041.985)
<!--EndFragment-->
Verification passed on
Brave | 1.26.45 Chromium: 91.0.4472.77 (Official Build) beta (64-bit) |
---|---|
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246} |
OS | Ubuntu 18.04 LTS |
stephendonner
added
QA Pass-macOS
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
May 27, 2021
rebron
changed the title
Brave News should require hard opt-in
Brave News should require explicit opt-in
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Previously it was deemed ok to not require an explicit opt-in for Brave News' remote network fetch because:
However, in the interests of caution we want to require the users to explicitly opt-in to the feature, including the privacy policy, before making any network requests.
The text was updated successfully, but these errors were encountered: