Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ad notification field trials #15624

Closed
tmancey opened this issue May 4, 2021 · 2 comments · Fixed by brave/brave-core#8705
Closed

Custom ad notification field trials #15624

tmancey opened this issue May 4, 2021 · 2 comments · Fixed by brave/brave-core#8705

Comments

@tmancey
Copy link
Contributor

tmancey commented May 4, 2021

No description provided.

@stephendonner
Copy link

stephendonner commented Jun 4, 2021

Verified PASSED using

Brave 1.26.52 Chromium: 91.0.4472.77 (Official Build) beta (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Launched Brave with a new profile, using --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="*CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_show_custom_notifications/true"

  • Confirmed the default position of custom ad notifications on macOS is top-right, just to the left of system notifications
  • Confirmed the default ad notification timeout for custom ad notifications on macOS is 120 seconds
  • Confirmed using my imprecise eyes the default ad notification fade in/out animation duration for custom ad notifications is 200 milliseconds (also ran with --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="*CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_show_custom_notifications/true/ad_notification_timeout/0/ad_notification_fade_duration/2000" to see it more clearly, visually, as discussed with @tmancey)
default position still displayed @ 1:50 mark timed out @ ~2:00 mark
Screen Shot 2021-06-04 at 12 40 06 PM Screen Shot 2021-06-04 at 12 48 53 PM Screen Shot 2021-06-04 at 12 49 02 PM

Verification passed on

Brave 1.26.50 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#8705

Confirmed the default position of custom ad notifications on Linux are positioned top-right
image

Confirmed the default ad notification timeout for custom ad notifications on Linux is 120 seconds

[26159:26159:0607/104201.763616:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 824672d5-2d40-409d-a415-74f5f461cdf6
  creativeInstanceId: 7898a259-664a-4052-8382-9c7279ae3249
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad Set 2 - Creative 1 - Ad 1
  body: Ad Set 2 - Creative 1 - Ad 1
  targetUrl: https://youtube.com

Confirmed ad timeout and was hidden after 2 minutes


[26159:26159:0607/104401.763229:VERBOSE3:ad_notification_event_timed_out.cc(22)] Timed out ad notification with uuid 824672d5-2d40-409d-a415-74f5f461cdf6 and creative instance id 7898a259-664a-4052-8382-9c7279ae3249

Confirmed the default ad notification fade in/out animation duration for custom ad notifications is around 200 milliseconds


Verification passed on



<!--StartFragment-->
Brave | 1.26.50 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->


Verified test plan from brave/brave-core#8705

Confirmed the default position of custom ad notifications on Windows are positioned top-right
image

Confirmed the default ad notification timeout for custom ad notifications on Windows is 120 seconds

[2788:14672:0607/205059.898:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: 8697ef13-136c-4a18-896e-161a137f7548
  creativeInstanceId: 4983dc92-09fd-4e5c-94c3-616a4728c1d9
  creativeSetId: 5bdeab83-048f-48a7-9602-a1092ded123c
  campaignId: 63010037-c230-40db-b41a-3127619b88e4
  advertiserId: 8d2f4191-b76e-4369-8983-3d9ff551c5ad
  segment: untargeted
  title: This is a test
  body: This is a test
  targetUrl: https://www.brave.com

Confirmed ad timeout and was hidden after 2 minutes

[2788:14672:0607/205059.898:VERBOSE1:ads_service_impl.cc(1819)] Timeout ad notification with uuid 8697ef13-136c-4a18-896e-161a137f7548 in 120 seconds

Confirmed the default ad notification fade in/out animation duration for custom ad notifications is around 200 milliseconds

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 14, 2021

Verification passed on Samsung Galaxy Tab version 10 running brave Beta build Bravemonoarm64 1.26.56.apk

  • Confirmed the default ad notification timeout for custom ad notifications on Android is 30 seconds
  • Confirmed ad timeout and Ad was hidden after 30 secs

Custom ad:

Screenshot_20210614-161219_Brave - Beta

2021-06-14 16:12:02.344 27609-27609/? V/chromium: [VERBOSE1:ads_service_impl.cc(1819)] Timeout ad notification with uuid 0e817ee3-acf3-4c0f-b220-909eb2b83dec in 30 seconds
2021-06-14 16:12:02.346 27609-27609/? V/chromium: [VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
      uuid: 0e817ee3-acf3-4c0f-b220-909eb2b83dec
      creativeInstanceId: 9fa9d489-489c-4754-84d7-ce18df4c89e6
      creativeSetId: 29137bce-786a-462d-ae4d-1228b751c344
      campaignId: 94a2044b-4d21-4414-a47d-a9f318893dc6
      advertiserId: 93ae4e2f-7745-4ca0-b7f7-e11823b966c1
      segment: business
      title: Upland: Blockchain Metaverse
      body: Collect virtual land of the real world. 6000 UPX Bonus!
      targetUrl: https://www.upland.me/landing/brave-push-sea-engl-06-2021
2021-06-14 16:12:02.383 27609-27609/? V/chromium: [VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 0e817ee3-acf3-4c0f-b220-909eb2b83dec and creative instance id 9fa9d489-489c-4754-84d7-ce18df4c89e6
2021-06-14 16:12:02.384 27609-27609/? V/chromium: [VERBOSE1:confirmations.cc(89)] Confirming view ad for creative instance id 9fa9d489-489c-4754-84d7-ce18df4c89e6

Timeout:

2021-06-14 16:12:02.344 27609-27609/? V/chromium: [VERBOSE1:ads_service_impl.cc(1819)] Timeout ad notification with uuid 0e817ee3-acf3-4c0f-b220-909eb2b83dec in 30 seconds

Verification passed on OnePlus 6T with Android 10 running 1.26.59 x64 Beta build

  • Verified default timeout for custom ad notification is 30 secs
  • Verified ad notification auto-dismiss after 30 secs


2021-06-14 09:24:56.314 27076-27076/? V/chromium: [VERBOSE1:ads_service_impl.cc(1819)] Timeout ad notification with uuid aae4a19c-261c-4a47-8aba-b5f11b7d08b5 in 30 seconds
2021-06-14 09:24:56.315 27076-27076/? V/chromium: [VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
      uuid: aae4a19c-261c-4a47-8aba-b5f11b7d08b5
      creativeInstanceId: 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed
      creativeSetId: 5f8c4787-8431-49a5-9d09-bba40f8ad5f4
      campaignId: d1e25388-b362-4f30-bd4b-36b8205e59e5
      advertiserId: a34de75d-5654-4331-8713-8f4d4e2b6bf7
      segment: untargeted
      title: Vivamus sagittis lacus vel aug
      body: Duis mollis, est non commodo luctus, nisi erat porttitor lig
      targetUrl: https://www.apple.com
2021-06-14 09:24:56.335 27076-27076/? V/chromium: [VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid aae4a19c-261c-4a47-8aba-b5f11b7d08b5 and creative instance id 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed
2021-06-14 09:25:26.343 27076-27076/? V/chromium: [VERBOSE3:ad_notification_event_timed_out.cc(22)] Timed out ad notification with uuid aae4a19c-261c-4a47-8aba-b5f11b7d08b5 and creative instance id 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants