Fix handling of Rewards disabled state for various P3A questions

[emerick]

Description

Due to recent changes to Rewards, the "Rewards disabled" bucket for several of our P3A questions is never triggered correctly.

Steps to Reproduce

1. Clean profile
2. Visit brave://rewards
3. Wait 10-20 seconds and check Brave.Rewards.AutoContributionsState.2 in brave://local-state
4. Enable Rewards
5. Wait 10-20 seconds and check Brave.Rewards.AutoContributionsState.2 in brave://local-state
6. Disable Rewards (i.e., turn off Ads and Auto-Contribute)
7. Wait 10-20 seconds and check Brave.Rewards.AutoContributionsState.2 in brave://local-state

Actual result:

Step 3 - Brave.Rewards.AutoContributionsState.2 not set at all
Step 5 - Brave.Rewards.AutoContributionsState.2 set to 3
Step 7 - Brave.Rewards.AutoContributionsState.2 set to 2

Expected result:

Step 3 - Brave.Rewards.AutoContributionsState.2 set to 1
Step 5 - Brave.Rewards.AutoContributionsState.2 set to 3
Step 7 - Brave.Rewards.AutoContributionsState.2 set to 1

Reproduces how often:

Easily

Brave version (brave://version info)

Current master.

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[stephendonner]

Verified PASSED using the inline testplan with build

Brave	1.25.34 Chromium: 90.0.4430.85 (Official Build) nightly (x86_64)
Revision	5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS	macOS Version 11.2.3 (Build 20D91)

Steps:

1. Clean profile
2. Visited brave://rewards
3. Waited 10-20 seconds and checked Brave.Rewards.AutoContributionsState.2 in brave://local-state
4. Enabled Rewards
5. Waited 10-20 seconds and checked Brave.Rewards.AutoContributionsState.2 in brave://local-state
6. Disabled Rewards (i.e., turned off Ads and Auto-Contribute)
7. Waited 10-20 seconds and checked Brave.Rewards.AutoContributionsState.2 in brave://local-state

Step 3: verified the value of Brave.Rewards.AutoContributionsState.2 was 1
Step 5: verified the value of Brave.Rewards.AutoContributionsState.2 was 3
Step 7: verified the value of Brave.Rewards.AutoContributionsState.2 was 1

step 3	enabled Rewards	step 5	disable Rewards	step 7

---

Verification passed on

Brave | 1.25.53 Chromium: 90.0.4430.93 (Official Build) beta (64-bit)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2004 (Build 19041.928)

• Verified the STR from the description

Step 3: verified the value of Brave.Rewards.AutoContributionsState.2 was 1
Step 5: verified the value of Brave.Rewards.AutoContributionsState.2 was 3
Step 7: verified the value of Brave.Rewards.AutoContributionsState.2 was 1

step 3	enabled Rewards	step 5	disable Rewards	step 7

---

Verification passed on

Brave	1.25.59 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	Ubuntu 18.04 LTS

• Verified the STR from the description

Step 3: verified the value of Brave.Rewards.AutoContributionsState.2 was 1
Step 5: verified the value of Brave.Rewards.AutoContributionsState.2 was 3
Step 7: verified the value of Brave.Rewards.AutoContributionsState.2 was 1

step 3	enabled Rewards	step 5	disable Rewards	step 7