Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

study_filtering.cc logs are missing in release #15162

Closed
btlechowski opened this issue Apr 7, 2021 · 3 comments
Closed

study_filtering.cc logs are missing in release #15162

btlechowski opened this issue Apr 7, 2021 · 3 comments

Comments

@btlechowski
Copy link

Follow up to #14613

The test plan from brave/brave-core#8216 requires to Verify in logs that study loaded correctly with [10210:775:0313/084147.162484:VERBOSE1:study_filtering.cc(346)] Kept study AdvertiserSplitTestingStudy.
The log message is never shown.

Steps to Reproduce

  1. Follow Notification ad - GroupA from https://github.com/brave/internal/issues/762

Actual result:

study_filtering.cc logs are missing

Expected result:

study_filtering.cc logs are present
Example from test plan brave/brave-core#8216

[10210:775:0313/084147.162484:VERBOSE1:study_filtering.cc(346)] Kept study AdvertiserSplitTestingStudy

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.23.63 Chromium: 89.0.4389.114 (Official Build) beta (64-bit)
Revision 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS Ubuntu 18.04 LTS

cc @moritzhaller @tmancey @jsecretan @brave/legacy_qa

@moritzhaller
Copy link

I've noticed these logs are not showing on release builds. Maybe @iefremov can help?

@iefremov
Copy link
Contributor

yeah this is expected, since those are debug logs

@tmancey
Copy link
Contributor

tmancey commented Apr 30, 2021

Closing issue as working as expected

@tmancey tmancey closed this as completed Apr 30, 2021
@tmancey tmancey self-assigned this Apr 30, 2021
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants