-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document windows installers available flags #14971
Comments
cc: @mihaiplesa Any help with this one? |
@mherrmann is looking into a few related things but there's some info on: I'll create wiki page to capture. |
A good default assumption is that Brave installers on Windows support the same command line arguments as Chrome's. |
Trying to find their docs for that but nothing so far. |
@mherrmann is correct. Further, we've listed them on our Help Center for reference. |
@Brave-Matt those ar run-time, not sure we have for install time (options for the installer). Partly present at https://github.com/google/omaha/blob/master/doc/UsingOmaha.md |
Brave's installers on Windows are Tagged Meta Installers. Their command-line parsing logic is implemented here. This essentially says that if you pass |
@jaysonsantos does the above answer your questions? If yes, then we'd go ahead and close this issue. |
Hey there @mherrmann sute thing, this can be closed |
Thank you for letting me know @jaysonsantos ! |
@mherrmann anything we should add to https://github.com/brave/brave-browser/wiki/Brave-omaha? |
@bsclifton @mihaiplesa and I considered the same question. There's nothing that can be added easily. It would require going through Omaha's C++ code, seeing what flags might be there, reading the code to find out what they do and potentially trying it. We decided to leave it at that if @jaysonsantos' questions were answered. |
Description
I'd like to know what are the possible command-line flags for the installer, I am trying to update an installation recipe for brave on scoop, and the zipped files are not signed so I wanted to use the installers but I cannot find what kind of installer it is and its flags.
Steps to Reproduce
installer.exe /?
installer.exe /help
won't print anything
Actual result:
nothing on the command line, the installer keeps going
Expected result:
information about the install flags
Brave version (brave://version info)
Brave | 1.22.70 Chromium: 89.0.4389.105 (Official Build) (64-bit)
Revision | 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS | Windows 10 OS Version 2009 (Build 19042.870)
Version/Channel Information:
Miscellaneous Information:
If you just point out what installer framework you are using it should also be ok.
Thanks in advance
The text was updated successfully, but these errors were encountered: