Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update l10n for 1.23.x release (Chromium 90). #14956

Closed
mkarolin opened this issue Mar 25, 2021 · 3 comments · Fixed by brave/brave-core#8494
Closed

Update l10n for 1.23.x release (Chromium 90). #14956

mkarolin opened this issue Mar 25, 2021 · 3 comments · Fixed by brave/brave-core#8494

Comments

@mkarolin
Copy link
Contributor

Download the latest l10n from Transifex.

Test plan:

@brave/legacy_qa should run through a few locals just to make sure that nothing obvious has regressed. Shouldn't spend too much time on this though.

Fix to this issue should also address:

@LaurenWags
Copy link
Member

Adding QA/Blocked until a new RC is built

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 14, 2021

Verification passed on

Brave | 1.23.70 Chromium: 90.0.4430.70 (Official Build) (64-bit)
-- | --
Revision | 3954de7175366f3b7edca576f140dfa273e6b5ae-refs/branch-heads/4430@{#1210}
OS | Windows 10 OS Version 2004 (Build 19041.867)

Verified the issues #14862#14864 in Kannada and Hindi locale and ensured Method to resolve Unstoppable Domains and Method to resolve Ethereum Name Service (ENS) dropdown items are translated

Kannada Hindi
image image
Kannada Hindi
image image

Ensured new strings avatar menu items , Top sites settings and new settings added in brave://settings/content are translated in Kannada

Example Example Example
image image image
Example Example Example Example
image image image image

Your device use settings in brave://settings/content is translated to Kannada

Example Example
image image
  • Verified NTP, Rewards settings, Rewards panel, brave settings, PT and TOR tab and ensured there are no regressions found

@srirambv
Copy link
Contributor

  • Verification passed on OnePlus 6T with Android 10 running 1.23.70 x64 build
  • Verification passed on Samsung Tab A with Android 10 running 1.23.70 x64 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants