Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Don't show default browser prompt if other brave channel is already set as a default #14078

Closed
deeppandya opened this issue Feb 10, 2021 · 3 comments · Fixed by brave/brave-core#7955

Comments

@deeppandya
Copy link
Contributor

deeppandya commented Feb 10, 2021

Currently we show set brave as default browser in all channels i.e. release, beta and nightly. So this issue is to set the behaviour If brave's any channel is already set as a default browser, the other installs should not show any options for default browser.
For context, related issue for desktop : #13980

Note :
Whenever we install any app with an intent of being a web browser, android system resets the default selection. So let's say if nightly was already a default browser, and if you install beta, android system would reset the default selection as it considers that we are installing new browser because we are not happy with previous selection.

@deeppandya deeppandya added QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Feb 10, 2021
@deeppandya deeppandya self-assigned this Feb 10, 2021
@srirambv
Copy link
Contributor

So this issue is to show set brave as default modal only on release channel;.

@deeppandya should it only show for Release channel or similar to desktop it should not prompt if one of the channel is set as default?

@deeppandya deeppandya changed the title Show set as default modal for release channel only [Android] Don't show default browser prompt if other brave channel is already set as a default Feb 12, 2021
@deeppandya
Copy link
Contributor Author

So this issue is to show set brave as default modal only on release channel;.

@deeppandya should it only show for Release channel or similar to desktop it should not prompt if one of the channel is set as default?

@srirambv i have updated the issue to be in sync with desktop implementation.

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.21.68 x64 build

OnePlus.6T.Default.Browser.mp4

Verification passed on OnePlus 6T with Android 10 running 1.21.68 x64 build

Samsung.Tab.Default.browser.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants