Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement swipe-to-dismiss for Brave Ads custom ad notifications #13038

Closed
yachtcaptain23 opened this issue Dec 3, 2020 · 2 comments · Fixed by brave/brave-core#7293
Closed
Assignees
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@yachtcaptain23
Copy link

No description provided.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 8, 2021

Removing this from https://github.com/brave/brave-browser/milestone/161 as brave/brave-core#7293 is still opened on master and nothing has been merged. Please only move issues once they've been fixed/merged into the associated milestone.

@kjozwiak kjozwiak removed this from the 1.20.x - Release milestone Feb 8, 2021
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude enhancement labels May 19, 2021
@tmancey tmancey added this to the 1.26.x - Nightly milestone May 19, 2021
@tmancey tmancey changed the title Implement swipe-to-dismiss for Ads notifications Implement swipe-to-dismiss for Brave Ads custom ad notifications May 20, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 11, 2021

Verification passed on Samsung Galaxy Tab version 10 running brave Beta build Bravemonoarm64 1.26.56.apk
Verified the test plan from brave/brave-core#7293

Confirmed custom ads are served to the users

2021-06-11 13:26:49.298 20754-20754/? V/chromium: [VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
      uuid: 904af66a-a82b-449a-b86c-2e95ba2b047c
      creativeInstanceId: 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed
      creativeSetId: 5f8c4787-8431-49a5-9d09-bba40f8ad5f4
      campaignId: d1e25388-b362-4f30-bd4b-36b8205e59e5
      advertiserId: a34de75d-5654-4331-8713-8f4d4e2b6bf7
      segment: untargeted
      title: Vivamus sagittis lacus vel aug
      body: Duis mollis, est non commodo luctus, nisi erat porttitor lig
      targetUrl: https://www.apple.com

Click

2021-06-10 23:38:12.226 31360-31360/? V/chromium: [VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 82ee43e1-88a3-4ba6-ac49-ca45dd119062, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and click
2021-06-10 23:38:12.227 31360-31360/? V/chromium: [VERBOSE1:confirmations.cc(271)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 5 unblinded payment tokens

View - Confirmed tokens are redeemed successfully for the View event

2021-06-10 23:22:06.736 29845-29845/? V/chromium: [VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 1b108149-3f4a-47d9-bf5a-f3ac36dd468e, creative instance id 7898a259-664a-4052-8382-9c7279ae3249 and view
2021-06-10 23:22:06.738 29845-29845/? V/chromium: [VERBOSE1:confirmations.cc(271)] Added 1 unblinded payment token with an estimated redemption value of 0.05 BAT, you now have 3 unblinded payment tokens

Landed

2021-06-10 23:38:24.964 31360-31360/? V/chromium: [VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id c53bfa64-8005-4b45-8f89-154cc3d01c33, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and landed
2021-06-10 23:38:24.967 31360-31360/? V/chromium: [VERBOSE1:confirmations.cc(271)] Added 1 unblinded payment token with an estimated redemption value of 0 BAT, you now have 6 unblinded payment tokens

Verification passed on OnePlus 6T with Android 10 running 1.26.59 x64 Beta build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/ads OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants