Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number formatting incorrect for Crypto.com widget #12816

Closed
AlanBreck opened this issue Nov 20, 2020 · 1 comment · Fixed by brave/brave-core#7214
Closed

Number formatting incorrect for Crypto.com widget #12816

AlanBreck opened this issue Nov 20, 2020 · 1 comment · Fixed by brave/brave-core#7214

Comments

@AlanBreck
Copy link

Description

Number format is currently displaying for en-IN on details view.

Steps to Reproduce

  1. Open Brave Beta
  2. Open new tab
  3. Focus Crypto.com widget
  4. Click through to details view on BTC
  5. Observe problem

Actual result:

Screen Shot 2020-11-20 at 12 54 55 PM

Expected result:

Screen Shot 2020-11-20 at 12 56 03 PM

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

srirambv commented Jan 5, 2021

Verification passed on

Brave 1.19.72 Chromium: 87.0.4280.101 (Official Build) beta (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Linux
  • Verified number formatting is as per expected design
    image

Verification passed on

Brave 1.19.72 Chromium: 87.0.4280.101 (Official Build) beta (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 10 OS Version 2009 (Build 19042.685)
  • Verified number formatting is as per expected design
    image

Verification passed on

Brave 1.19.72 Chromium: 87.0.4280.101 (Official Build) beta (x86_64)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS macOS Version 10.15.7 (Build 19H2)
  • Verified number formatting is as per expected design
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment