You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Via analysing crash stacks on dev play console I found out that we often crash on that place https://github.com/brave/brave-core/blob/1.16.x/browser/android/brave_cosmetic_resources_tab_helper.cc#L81
That is place is better to rewrite to use frame_id instead of a raw pointer, that way we can check if the host is still alive after IO operations.
It looks like it happens non consistently sometimes in diff behaviour, I wasn't able to replicate that.
Steps to reproduce
No steps unfortunately
Actual result
Sometimes crashes randomly on browsing
Expected result
No crashes
Issue reproduces how often
0 times for me, but we have plenty of reports about crashes lately.
Version/Channel Information:
every channel, starting from 1.16.x
Can you reproduce this issue with the current Play Store version?
Can you reproduce this issue with the current Play Store Beta version?
Can you reproduce this issue with the current Play Store Nightly version?
Device details
Install type (ARM, x86):
Device type (Phone, Tablet, Phablet):
Android version:
Brave version
Website problems only
Does the issue resolve itself when disabling Brave Shields?
Does the issue resolve itself when disabling Brave Rewards?
Is the issue reproducible on the latest version of Chrome?
Additional information
The text was updated successfully, but these errors were encountered:
Description
Via analysing crash stacks on dev play console I found out that we often crash on that place https://github.com/brave/brave-core/blob/1.16.x/browser/android/brave_cosmetic_resources_tab_helper.cc#L81
That is place is better to rewrite to use frame_id instead of a raw pointer, that way we can check if the host is still alive after IO operations.
It looks like it happens non consistently sometimes in diff behaviour, I wasn't able to replicate that.
Steps to reproduce
No steps unfortunately
Actual result
Sometimes crashes randomly on browsing
Expected result
No crashes
Issue reproduces how often
0 times for me, but we have plenty of reports about crashes lately.
Version/Channel Information:
every channel, starting from
1.16.x
Device details
Brave version
Website problems only
Additional information
The text was updated successfully, but these errors were encountered: