Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on cosmetic filters tab helper #12745

Closed
SergeyZhukovsky opened this issue Nov 17, 2020 · 0 comments · Fixed by brave/brave-core#7171
Closed

Crash on cosmetic filters tab helper #12745

SergeyZhukovsky opened this issue Nov 17, 2020 · 0 comments · Fixed by brave/brave-core#7171
Assignees
Labels
crash OS/Android Fixes related to Android browser functionality QA/No release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

Description

Via analysing crash stacks on dev play console I found out that we often crash on that place https://github.com/brave/brave-core/blob/1.16.x/browser/android/brave_cosmetic_resources_tab_helper.cc#L81
That is place is better to rewrite to use frame_id instead of a raw pointer, that way we can check if the host is still alive after IO operations.
It looks like it happens non consistently sometimes in diff behaviour, I wasn't able to replicate that.

Steps to reproduce

No steps unfortunately

Actual result

Sometimes crashes randomly on browsing

Expected result

No crashes

Issue reproduces how often

0 times for me, but we have plenty of reports about crashes lately.

Version/Channel Information:

every channel, starting from 1.16.x

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Android Fixes related to Android browser functionality QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants