Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Automatically redirect .onion site" setting does not work in Guest windows #12644

Open
LaurenWags opened this issue Nov 11, 2020 · 1 comment

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #806

If "Automatically redirect .onion site" is toggled on in settings and you visit brave.com in a normal or private window, a Tor window is opened and automatically navigated to the onion site for Brave. If you do this in a guest window, you get the "Open in Tor" option in the URL bar, you are not automatically navigated.

Steps to Reproduce

From brave/brave-core#6762, Automatically redirect .onion site TC

  1. Go to brave://settings/extensions
  2. Toggle on "Automatically redirect .onion site"
  3. In a Normal or Private window navigate to brave.com
  4. https://brave5t5rjjg3s6k.onion will be opened in Tor window (if the tab from step 3 is not the only tab in the window, it will be closed)
  5. Close Tor Window.
  6. Open guest window
  7. Navigate to brave.com

Actual result:

Guest

Expected result:

Automatically navigated to brave onion site in Tor window.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.17.67 Chromium: 87.0.4280.49 (Official Build) unknown (x86_64)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@darkdh
Copy link
Member

darkdh commented Nov 13, 2020

The setting of guest window is different than regular profile, so the setting you just changed doesn't affect guest window. You can open settings page from guest window and we don't expose the auto redirect onion setting to guest window

@rebron rebron changed the title [Desktop] "Automatically redirect .onion site" setting does not work in Guest windows "Automatically redirect .onion site" setting does not work in Guest windows Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants