Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show background images in Dashboard Settings is not translated #11792

Closed
btlechowski opened this issue Sep 21, 2020 · 1 comment
Closed

Show background images in Dashboard Settings is not translated #11792

btlechowski opened this issue Sep 21, 2020 · 1 comment

Comments

@btlechowski
Copy link

Follow up to #7947.
Show background images is not translated

Steps to Reproduce

  1. Clean profile
  2. Open Brave in German(DE) locale
  3. Open Dashboard Settings on NTP

Actual result:

Show background images in Dashboard Settings is not translated
image

Expected result:

Show background images in Dashboard Settings is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Ubuntu 18.04 LTS
Brave 1.16.19 Chromium: 86.0.4240.30 (Official Build) nightly (64-bit)
Revision 09f50eb5535879364cf00e72653462a509ef6bdc-refs/branch-heads/4240@{#552}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @mkarolin

@btlechowski
Copy link
Author

btlechowski commented Oct 14, 2020

Verification passed on

Brave 1.17.32 Chromium: 86.0.4240.80 (Official Build) nightly (64-bit)
Revision 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183}
OS Ubuntu 18.04 LTS

Verified test plan from the description

German locale:
image

Polish locale:
image


Verification passed on


Brave | 1.17.39 Chromium: 86.0.4240.99 (Offizieller Build) nightly (64-Bit)
-- | --
Überarbeitung | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
Betriebssystem | Windows 10 OS Version 1903 (Build 18362.1082)

  • Verified test plan from the description

German locale:
image

Hindi locale
image

Kannada locale
image


Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave | 1.17.42 Chromium: 86.0.4240.99 (Official Build) nightly (x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.15.7 (Build 19H2)
JavaScript | V8 8.6.395.13
German Chinese Japanese
Bildschirmfoto 2020-10-20 um 1 14 52 PM 截圖 2020-10-20 下午1 15 20 スクリーンショット 2020-10-20 1 16 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants