Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Location permission under site settings lists app as Chrome instead of Brave #11668

Closed
srirambv opened this issue Sep 11, 2020 · 2 comments
Labels
branding bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Location permission under site settings lists app as Chrome instead of Brave

Steps to reproduce

  1. Install 1.10.99
  2. Visit google.com and open site settings
  3. Shows Turn on permissions for Brave in Android Settings
  4. Upgrade to 1.11.105
  5. Open site settings for google.com
  6. Shows Turn on permissions for Chrome in Android Settings

Actual result

sitesettings

Expected result

image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: 10

Brave version

1.11.105

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@anthonypkeane @bsclifton Added P2 to get it uplifted for 1.14.x please modify it if required.

@srirambv srirambv added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include regression branding OS/Android Fixes related to Android browser functionality labels Sep 11, 2020
@bsclifton
Copy link
Member

Fixed on Nightly / Chromium 86. Putting in 1.15 so we can verify

@srirambv
Copy link
Contributor Author

  • Verification passed on OnePlus 6T with Android 10 running 1.15.66 x64 beta build
    image
  • Verification passed on OnePlus 6T with Android 10 running 1.15.66 x64 beta build
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branding bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/exclude
Projects
None yet
Development

No branches or pull requests

2 participants