Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Enable DNS over HTTPS UI setting #11312

Closed
fmarier opened this issue Aug 18, 2020 · 7 comments
Closed

[Desktop] Enable DNS over HTTPS UI setting #11312

fmarier opened this issue Aug 18, 2020 · 7 comments
Assignees
Labels
closed/not-actionable OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude security

Comments

@fmarier
Copy link
Member

fmarier commented Aug 18, 2020

Chromium 84 includes a user-visible DoH setting:
download

controlled by this feature flag.

@rebron rebron added malware-false-positive A third-party tool flags Brave or a related component as malware. OS/Android Fixes related to Android browser functionality labels Aug 19, 2020
@rebron rebron changed the title [Desktop] Enable DNS over HTTPS UI setting [Desktop] [Android] Enable DNS over HTTPS UI setting Aug 19, 2020
@rebron rebron removed the OS/Android Fixes related to Android browser functionality label Aug 19, 2020
@rebron rebron changed the title [Desktop] [Android] Enable DNS over HTTPS UI setting [Desktop] Enable DNS over HTTPS UI setting Aug 19, 2020
@rebron rebron added design A design change, especially one which needs input from the design team and removed malware-false-positive A third-party tool flags Brave or a related component as malware. labels Aug 19, 2020
@Johann999
Copy link

The DOH settings should always be displayed, regardless of whether the flag 'Secure DNS' is set or whether the browser is managed.

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 25, 2020
@diracdeltas
Copy link
Member

diracdeltas commented Oct 5, 2020

We are seeing support requests for this feature now that it's available in Chrome 85 by default: https://twitter.com/Ginger__T/status/1313059566964400129

Is this just waiting on a design from @karenkliu?

@diracdeltas
Copy link
Member

We probably just want to copy the Chrome UI for this in brave://settings/security > advanced:

Screen Shot 2020-10-05 at 12 09 56 PM

@karenkliu
Copy link

let's do what @diracdeltas suggested - probably don't need a design for this one

@diracdeltas diracdeltas removed the design A design change, especially one which needs input from the design team label Oct 5, 2020
@diracdeltas diracdeltas assigned diracdeltas and unassigned rebron Dec 15, 2020
@diracdeltas
Copy link
Member

diracdeltas commented Dec 30, 2020

Seems like this has been fixed. I verified that the setting exists in 1.18 stable and that https://www.cloudflare.com/ssl/encrypted-sni/ shows that DoH is being used once i set the provider to cloudflare 1.1.1.1

@mKoonrad
Copy link

I can confirm that it's working on Windows but not on Linux (1.18.77 Chromium: 87.0.4280.101)

@fmarier
Copy link
Member Author

fmarier commented Dec 31, 2020

I can confirm that it's working on Windows but not on Linux (1.18.77 Chromium: 87.0.4280.101)

Support for DoH in general is not yet available on Linux (in Chrome or Brave).

@rebron rebron added the QA/No label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/not-actionable OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude security
Projects
None yet
Development

No branches or pull requests

6 participants