Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Uphold server url handling #11286

Closed
NejcZdovc opened this issue Aug 18, 2020 · 1 comment · Fixed by brave/brave-core#6511
Closed

[Desktop] Uphold server url handling #11286

NejcZdovc opened this issue Aug 18, 2020 · 1 comment · Fixed by brave/brave-core#6511
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.15.x - Release #1

Comments

@NejcZdovc
Copy link
Contributor

Ref: #10987
@NejcZdovc NejcZdovc self-assigned this Aug 18, 2020
@NejcZdovc NejcZdovc mentioned this issue Aug 18, 2020
Closed
6 tasks
@NejcZdovc NejcZdovc added this to the 1.15.x - Nightly milestone Aug 26, 2020
@NejcZdovc NejcZdovc mentioned this issue Aug 26, 2020
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 26, 2020
@NejcZdovc
Adds uphold server handler
0b788bc 
Resolves brave/brave-browser#11286
@LaurenWags LaurenWags mentioned this issue Sep 21, 2020
Closed
This was referenced Sep 22, 2020
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Sep 22, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave	1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision	ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6511

Using a wallet funded only via Uphold KYC'd BAT, confirmed able to do 1 time tips, recurring tips, and AC using KYC'd Uphold wallet (staging env) Uphold1 Uphold2 Uphold3 Uphold4 Uphold5
Confirmed brave://rewards-internals showed data from above Uphold contributions (1 time tips, recurring tips, AC) as expected Uphold6
Connect brand new KYC
  1. Clean profile, staging, enabled rewards
  2. Confirmed able to restore a wallet with an ad grant waiting and claim ad grant.
  3. Due to required balance needed, claimed UGP grant also.
Uphold7
  1. Clicked Verify Wallet and signed up for Uphold account. Began KYC process.
Uphold8
  1. After account was KYC'd, confirmed Ad grant BAT only moved to Uphold. UGP grant BAT did not move to Uphold as expected.
Uphold9 Uphold10 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/........./claim
> Method: UrlMethod::POST
> Content: {"signedLinkingRequest":"eyJib..........
> Content Type: application/json; charset=utf-8
[12965:775:0922/143029.524692:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/.........../claim
> Result: Success
> HTTP Code: 200
> Body: null

[12965:775:0922/143029.542070:VERBOSE5:ledger_impl.cc(128)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":"dui7F.................
[12965:775:0922/143030.070848:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body:
Uphold11 Uphold12 Uphold13
Connect existing KYC
  1. Clean profile, staging, enabled rewards
  2. Confirmed able to restore a wallet with an ad grant waiting and claim ad grant.
Uphold14
  1. Clicked Verify Wallet and connected an already KYC'd Uphold account
  2. Confirmed ad grant was transferred to Uphold
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/............/claim
> Method: UrlMethod::POST
> Content: {"signedLinkingRequest":"eyJ...........
> Content Type: application/json; charset=utf-8
[13232:775:0922/153648.614576:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/............/claim
> Result: Success
> HTTP Code: 200
> Body: null

[13232:775:0922/153648.630579:VERBOSE5:ledger_impl.cc(128)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":"dui7FOe................
[13232:775:0922/153649.230570:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body:
Uphold15 Uphold16

Verification passed on

Brave 1.15.63 Chromium: 86.0.4240.55 (Official Build) dev (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6511

Using a wallet funded only via Uphold KYC'd BAT, confirmed able to do 1 time tips, recurring tips, and AC using KYC'd Uphold wallet (staging env)

image
image
image
image

Confirmed brave://rewards-internals showed data from above Uphold contributions (1 time tips, recurring tips, AC) as expected

image

Connect brand new KYC
  1. Clean profile, staging, enabled rewards
  2. Confirmed able to restore a wallet with an ad grant waiting and claim ad grant.
  3. Due to required balance needed, claimed UGP grant also.

image

  1. Clicked Verify Wallet and signed up for Uphold account. Began KYC process.

image
image

  1. After account was KYC'd, confirmed Ad grant BAT only moved to Uphold. UGP grant BAT did not move to Uphold as expected.

image
image

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[]/claim
> Method: UrlMethod::POST
> Content: {"signedLinkingRequest":"eyJ
> Content Type: application/json; charset=utf-8
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/[]
> Result: Success
> HTTP Code: 200
> Body: null


[25705:25705:0928/083002.185498:VERBOSE5:ledger_impl.cc(128)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":"dui7
[25705:25705:0928/083002.710912:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200

image

Connect existing KYC
  1. Clean profile, staging, enabled rewards
  2. Confirmed able to restore a wallet with an ad grant waiting and claim ad grant.

image

  1. Clicked Verify Wallet and connected an already KYC'd Uphold account
  2. Confirmed ad grant was transferred to Uphold

image
image

Verification passed on


Brave | 1.15.65 Chromium: 86.0.4240.55 (Official Build) dev (64-bit)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Verified test plan from brave/brave-core#6511

Using a wallet funded only via Uphold KYC'd BAT, confirmed able to do 1 time tips, recurring tips, and AC using KYC'd Uphold wallet (staging env)

image
image
image
image
image

Confirmed brave://rewards-internals showed data from above Uphold contributions (1 time tips, recurring tips, AC) as expected

image

Connect brand new KYC
  1. Clean profile, staging, enabled rewards
  2. Confirmed able to restore a wallet with an ad grant waiting and claim ad grant.
  3. Due to required balance needed, claimed UGP grant also.

image

  1. Clicked Verify Wallet and signed up for Uphold account. Began KYC process.

image
image

  1. After account was KYC'd, confirmed Ad grant BAT only moved to Uphold. UGP grant BAT did not move to Uphold as expected.

image
image
image

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/.........../claim
> Method: UrlMethod::POST
> Content: {"signedLinkingRequest":
> Content Type: application/json; charset=utf-8
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/.........../claim
> Result: Success
> HTTP Code: 200
> Body: null
[14072:10960:0928/223706.158:VERBOSE5:ledger_impl.cc(128)]

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body:

image

image
image

Connect existing KYC
  1. Clean profile, staging, enabled rewards
  2. Confirmed able to restore a wallet with an ad grant waiting and claim ad grant.

image

  1. Clicked Verify Wallet and connected an already KYC'd Uphold account
  2. Confirmed ad grant was transferred to Uphold
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/........./claim
> Method: UrlMethod::POST
> Content: {"signedLinkingRequest":"eyJ......
> Content Type: application/json; charset=utf-8
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v3/wallet/uphold/........../claim
> Result: Success
> HTTP Code: 200
> Body: null

[3416:15696:0928/200109.838:VERBOSE5:ledger_impl.cc(128)]
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions/claim
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":".......=",
[ RESPONSE - OnRequest ]                                                                                                                                                                                           > Url: https://grant.rewards.bravesoftware.com/v1/suggestions/claim                                                                                                                                                > Result: Success                                                                                                                                                                                                  > HTTP Code: 200                                                                                                                                                                                                   > Body:       
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.15.x - Release #1
Development

Successfully merging a pull request may close this issue.

Adds uphold server handler brave/brave-core
4 participants
@NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya