Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Sync v2 - Bookmarks are duplicated after migration from sync v1 #11104

Closed
btlechowski opened this issue Aug 6, 2020 · 1 comment
Closed

Comments

@btlechowski
Copy link

All* the bookmarks are duplicated if user migrates from sync 1 to sync 2
The reason is that after upgrade to 1.12.x bookmarks are stripped of all the sync 1 meta data and are treated as local bookmarks. This is by design.

  • there could be a chance that a bookmark will get the same guid and won't be duplicated.

The problem is that the user may not realize that the bookmarks are now local and that they will sync to all the devices thus creating duplicates.
Even bigger problem is that we immediately encourage the user to create a sync v2 chain after migration.
image

Steps to Reproduce

  1. Install 1.11.x
  2. DeviceA: Bookmark few pages
  3. Create sync v1 chain
  4. Wait for sync
  5. Install 1.12.x
  6. Create sync v2 chain

Note: this issue can be easily replicated by just using sync 2

Actual result:

We encourage user to create sync v2 chain after upgrade which could result in bookmarks being duplicated
image
Bookmarks are duplicated after sync v2 chain is created
image

We also don't backup their bookmarks after upgrade to 1.12.x.

Expected result:

Bookmarks are not duplicated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS
@darkdh
Copy link
Member

darkdh commented Aug 6, 2020

The root cause is not even related to v1 and it can be reproducible with v2 only.
Close as invalid and use #11116 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants