[Desktop] Content Settings crash - Follow up to #10297

[kjozwiak]

Description

As per @iefremov via #10297 (comment), it appears like this is still crashing on 1.12.x, 1.13.x as per the following:

1.12.x Crashes:

https://brave.sp.backtrace.io/p/brave/explore?filters=((callstack%2Ccontains%2Ccontent_settings)%2C(ver%2Ccontains%2C%221.12%22))&aggregations=((ver%2Cdistribution)%2C(callstack%2Chead))

[ 00 ] base::Value::Clone() const
[ 01 ] content_settings::(anonymous namespace)::CloneRule(content_settings::Rule const&, bool)
[ 02 ] content_settings::BravePrefProvider::GetRuleIterator(ContentSettingsType, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool) const
[ 03 ] HostContentSettingsMap::GetContentSettingValueAndPatterns(content_settings::ProviderInterface const*, GURL const&, GURL const&, ContentSettingsType, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, ContentSettingsPattern*, ContentSettingsPattern*)
[ 04 ] HostContentSettingsMap::GetWebsiteSettingInternal(GURL const&, GURL const&, ContentSettingsType, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, HostContentSettingsMap::ProviderType, content_settings::SettingInfo*) const
[ 05 ] HostContentSettingsMap::GetWebsiteSetting(GURL const&, GURL const&, ContentSettingsType, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content_settings::SettingInfo*) const
[ 06 ] content_settings::CookieSettings::GetCookieSettingInternal(GURL const&, GURL const&, bool, content_settings::SettingSource*, ContentSetting*) const
[ 07 ] content_settings::CookieSettingsBase::IsCookieSessionOnly(GURL const&) const
[ 08 ] content::ServiceWorkerRegistry::OnStoragePolicyChanged()
[ 09 ] base::TaskAnnotator::RunTask(char const*, base::PendingTask*)
[ 10 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*)
[ 11 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
[ 12 ] base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
[ 13 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta)
[ 14 ] base::RunLoop::Run()
[ 15 ] content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*)
[ 16 ] base::Thread::ThreadMain()
[ 17 ] base::(anonymous namespace)::ThreadFunc(void*)
[ 18 ] 0x7f42d4c7b6db
[ 19 ] 0x7f42ce6f1a3f

1.13.x Crashes:

https://brave.sp.backtrace.io/p/brave/explore?filters=((ver%2Ccontains%2C%221.13%22)%2C(callstack%2Ccontains%2Ccontent_settings))&aggregations=((ver%2Cdistribution)%2C(callstack%2Chead))

[ 00 ] base::Value::Clone() const
[ 01 ] content_settings::(anonymous namespace)::CloneRule(content_settings::Rule const&, bool)
[ 02 ] content_settings::BravePrefProvider::GetRuleIterator(ContentSettingsType, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool) const
[ 03 ] HostContentSettingsMap::GetContentSettingValueAndPatterns(content_settings::ProviderInterface const*, GURL const&, GURL const&, ContentSettingsType, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, ContentSettingsPattern*, ContentSettingsPattern*)
[ 04 ] HostContentSettingsMap::GetWebsiteSettingInternal(GURL const&, GURL const&, ContentSettingsType, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, HostContentSettingsMap::ProviderType, content_settings::SettingInfo*) const
[ 05 ] HostContentSettingsMap::GetWebsiteSetting(GURL const&, GURL const&, ContentSettingsType, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content_settings::SettingInfo*) const
[ 06 ] content_settings::CookieSettings::GetCookieSettingInternal(GURL const&, GURL const&, bool, content_settings::SettingSource*, ContentSetting*) const
[ 07 ] content_settings::CookieSettingsBase::IsCookieSessionOnly(GURL const&) const
[ 08 ] content::ServiceWorkerRegistry::OnStoragePolicyChanged()
[ 09 ] base::TaskAnnotator::RunTask(char const*, base::PendingTask*)
[ 10 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*)
[ 11 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
[ 12 ] base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
[ 13 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta)
[ 14 ] base::RunLoop::Run()
[ 15 ] content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*)
[ 16 ] base::Thread::ThreadMain()
[ 17 ] base::(anonymous namespace)::ThreadFunc(void*)
[ 18 ] 0x7f95be2da6db
[ 19 ] 0x7f95b7d50a3f

Steps to Reproduce

• Currently don't have any STR that can be used to reproduce as we're getting the info from BackTrace. Hopefully once a developer takes a look at the crash stack, we might be able to get some STR/cases created.

Actual result:

Brave crashing due to content_settings as per the above crashes via BackTrace

Expected result:

Brave shouldn't be crashing.

Reproduces how often:

• N/A as we're getting the info from BackTrace. We'll need to get some STR/cases created as mentioned above.

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? I'm not 100% sure as I don't see anything from 1.14.x via BackTrace

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @iefremov @bsclifton @rebron @bridiver

[rebron]

cc: @kjozwiak to recheck with 1.14.81

[bsclifton]

Not seeing any instances of this on 1.13 or newer. Going to close out as it seems fix is working