Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync - history page should show tabs from other devices #10473

Closed
petemill opened this issue Jun 25, 2020 · 6 comments · Fixed by brave/brave-core#7121
Closed

Sync - history page should show tabs from other devices #10473

petemill opened this issue Jun 25, 2020 · 6 comments · Fixed by brave/brave-core#7121

Comments

@petemill
Copy link
Member

Chromium has tabs from other devices show on the history page. We currently hide that through commenting it all out via a patch. This can be added in, and the chromium gate on being 'signed in' can change to having sync enabled (with a link to set it up).

image

This screen should be changed to prompt to "Setup Sync with Brave Browser on other devices":

image

@GeetaSarvadnya
Copy link

Reproduced the issue in Windows 10 x64 - 1.12.104

@darkdh
Copy link
Member

darkdh commented Aug 13, 2020

without this section in history page, the menu will only show most recent 4 tabs

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Aug 21, 2020
@AlexeyBarabash
Copy link
Contributor

this is the same as #12391

@bsclifton
Copy link
Member

Set missing milestone

@rebron rebron changed the title [Desktop] Sync - history page should show tabs from other devices Sync - history page should show tabs from other devices Dec 15, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 24, 2020

Verification passed on


Brave | 1.19.66 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

Device A: Windows Brave Dev (1.19.x)
Device B: Windows Brave Nightly (1.20.x)
Device C: Android Release (1.18.x)

  • Open Device A->App menu->History, ensured that tabs from Device B are shown with more... items, also ensured that click on more... redirects to brave://history/syncedTabs page
    image
    image

  • Open Device B->App menu->History, ensured that tabs from Device B are shown with more... items, also ensured that click on more... redirects to brave://history/syncedTabs page
    image
    image


Verification passed on

Brave 1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

App menu->History
DeviceA
image

DeviceB
image

brave://history
DeviceA
image

DeviceB
image


Verified passed with

Brave	1.19.83 Chromium: 88.0.4324.79 (Official Build) (x86_64)
Revision	bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS	macOS Version 10.15.7 (Build 19H15)
Brave	1.19.83 Chromium: 88.0.4324.79 (Official Build) (arm64)
Revision	bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS	macOS Version 11.1 (Build 20C69)

Device A: macOS x64 with Catalina
Device B: macOS arm64 with Big Sur

Verified test plan from brave/brave-core#7121

Synced devices:

A B
Device A Screen Shot 2021-01-14 at 12 50 48 PM

Confirmed on both devices on brave://history, there is a section Tabs from other devices:

A B
Screen Shot 2021-01-14 at 11 41 34 AM Screen Shot 2021-01-14 at 12 50 33 PM

Confirmed Device A shows More... under History sub menu from hamburger menu.
Confirmed Device B does not show More... under History sub menu.

A B
Screen Shot 2021-01-14 at 11 42 41 AM Screen Shot 2021-01-14 at 11 43 12 AM

@OptimusPrime91
Copy link

OptimusPrime91 commented Jan 21, 2021

Still no support for iOS I guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

9 participants