-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmetic scriptlets not injected in iframes #10319
Labels
bug
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
webcompat/not-shields-related
Sites are breaking because of something other than Shields.
Milestone
Comments
antonok-edm
added
bug
webcompat/not-shields-related
Sites are breaking because of something other than Shields.
OS/Desktop
labels
Jun 16, 2020
32 tasks
This was referenced Jun 18, 2020
bsclifton
added
the
priority/P2
A bad problem. We might uplift this to the next planned release.
label
Jun 19, 2020
Labeled as P2 since this is causing ads to slip through for YouTube |
bsclifton
modified the milestones:
1.12.x - Nightly,
1.11.x - Beta,
1.10.x - Desktop Placeholder
Jun 20, 2020
This was referenced Jun 21, 2020
Verified passed with
Verification PASSED on
Verified passed using
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
webcompat/not-shields-related
Sites are breaking because of something other than Shields.
Currently, scriptlet injections from 3rd party contexts (i.e., cosmetic rules of the form
##+js()
) are only injected into the top level frame of a website. This sometimes causes issues inside of 3rd-party iframes, such as youtube embedded players.The text was updated successfully, but these errors were encountered: