Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic scriptlets not injected in iframes #10319

Closed
antonok-edm opened this issue Jun 16, 2020 · 2 comments · Fixed by brave/brave-core#5878
Closed

Cosmetic scriptlets not injected in iframes #10319

antonok-edm opened this issue Jun 16, 2020 · 2 comments · Fixed by brave/brave-core#5878
Assignees
Labels
bug OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@antonok-edm
Copy link
Collaborator

Currently, scriptlet injections from 3rd party contexts (i.e., cosmetic rules of the form ##+js()) are only injected into the top level frame of a website. This sometimes causes issues inside of 3rd-party iframes, such as youtube embedded players.

@bsclifton
Copy link
Member

Labeled as P2 since this is causing ads to slip through for YouTube

@LaurenWags
Copy link
Member

LaurenWags commented Jun 22, 2020

Verified passed with

Brave | 1.10.95 Chromium: 83.0.4103.106 (Official Build) (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | macOS Version 10.14.6 (Build 18G3020)

Verification PASSED on Mint 19.1 x64 using the following build:

Brave | 1.10.95 Chromium: 83.0.4103.106 (Official Build) (64-bit)
--- | ---
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | Linux

Verified passed using

Brave	1.10.95 Chromium: 83.0.4103.106 (Official Build) (64-bit)
Revision	ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS	Windows 10 OS Version 1809 (Build 17763.914)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants