Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] App crashes on opening new tab after disabling Custom Homepage theme #10296

Closed
chkk525 opened this issue Jun 16, 2020 · 1 comment · Fixed by brave/brave-core#5908
Closed

Comments

@chkk525
Copy link

chkk525 commented Jun 16, 2020

Description

  • With bottom toolbar off, app shutdown on opening a new tab page

Steps to reproduce

  1. Install Brave from a referral URL associated with Custom Homepage
  2. Disable the theme in the setting (choose Brave default theme)
  3. Open a new tab page
  4. App crashes

Actual result

  • App crash

Expected result

  • A new tab page should open

Issue reproduces how often

  • All the time

Issue happens on

  • Current Play Store version

Device details

  • Install type (ARM, x86): Arm
  • Device (Phone, Tablet, Phablet): OnePlus 7T
  • Android version: Android 10 (Oxygen OS 10.0.9)

Brave version

  • 1.9.80

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
    No

  • Does the issue resolve itself when disabling Brave Rewards?

  • Is the issue reproducible on the latest version of Chrome?

Additional information

@chkk525 chkk525 added the OS/Android Fixes related to Android browser functionality label Jun 16, 2020
@chkk525 chkk525 changed the title [Android] App shutdown on opening new tab if bottom toolbar is off [Android] App crushes on opening new tab if bottom toolbar is off Jun 16, 2020
@chkk525 chkk525 changed the title [Android] App crushes on opening new tab if bottom toolbar is off [Android] App crashes on opening new tab if bottom toolbar is off Jun 16, 2020
@chkk525 chkk525 changed the title [Android] App crashes on opening new tab if bottom toolbar is off [Android] App crashes on opening new tab after disabling Custom Homepage theme Jun 16, 2020
@deeppandya deeppandya self-assigned this Jun 18, 2020
@srirambv
Copy link
Contributor

srirambv commented Jun 22, 2020

Verification passed on Samsung Tab A with Android 9 running 1.10.95 x64 RC build

Verification passed on Gionee version 5.1 running Modernaram1.10.95.apk

  • Verified SI tab doesn't cause crash on load
  • Verified SI campaigns on multiple countries where it's running and no crash
  • Verified SR images doesn't cause crash when loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants