Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Show an infobar that sync v2 is coming #10231

Closed
petemill opened this issue Jun 11, 2020 · 6 comments
Closed

[Desktop] Show an infobar that sync v2 is coming #10231

petemill opened this issue Jun 11, 2020 · 6 comments

Comments

@petemill
Copy link
Member

petemill commented Jun 11, 2020

This would be for versions 1.11.x and above.

Text:

A new Brave Sync is coming. Get ready for the upgrade. More information

Link destination: https://brave.com/sync-v2-is-coming

@petemill
Copy link
Member Author

petemill commented Jun 30, 2020

Merged to v1.11.x via brave/brave-core#5806

@btlechowski
Copy link

Marking as QA/Blocked - need a new build to test, 1.11.92 or newer.

@LaurenWags
Copy link
Member

Removing QA/Blocked since https://github.com/brave/brave-browser/releases/tag/v1.11.92 is available

@LaurenWags
Copy link
Member

sync info bar disappears before I can interact with it - logged #10621 which blocks this issue from being tested.

@kjozwiak
Copy link
Member

Removing QA/Blocked as brave/brave-core#6070 was merged.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 14, 2020

Verified passed with

Brave	1.11.96 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision	19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS	macOS Version 10.14.6 (Build 18G3020)

Additional scenarios checked:
Scenario 1:

  1. Install 1.10.97
  2. Enable brave://flags flag for brave sync
  3. Restart, dismiss default browser bar
  4. Create a sync chain at brave://sync
  5. Update to 1.11.x
  6. Confirm info bar is shown

Scenario 2:

  1. Install 1.10.97
  2. Leave sync flag as Default (sync is disabled)
  3. Restart, dismiss default browser bar
  4. Update to 1.11.x
  5. Confirm no info bar is shown

Scenario 3:

  1. Install 1.10.97
  2. Set sync flag to Disabled
  3. Restart, dismiss default browser bar
  4. Update to 1.11.x
  5. Confirm no info bar is shown

Scenario 4:

  1. Install 1.10.97
  2. Set sync flag to Enabled
  3. Restart, dismiss default browser bar
  4. Set up sync chain
  5. Set sync flag to Disabled
  6. Restart browser.
  7. Update to 1.11.x
  8. Confirm no info bar is shown

Screen Shot 2020-07-14 at 1 44 22 PM


Verification passed on


Brave | 1.11.96 Chromium: 84.0.4147.89 (Official Build) (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.900)

Test A: - PASS

  • Verified that the info bar is shown A new Brave Sync is coming and will affect your setup. Get ready for the upgrade
    image

Test B: - PASS

  • Verified that click on Learn more removed the sync info bar

Test C: - PASS

  • Verified that click on x and restart browser removed the sync info bar

  • Verified the scenarios (1 to 4) mentioned above and ensured which are working as expected.

Additional scenarios checked:
Scenario 1:

  1. Install 1.10.97
  2. Enable brave://flags flag for brave sync
  3. Restart, dismiss default browser bar
  4. Create a sync chain at brave://sync
  5. Update to 1.11.x
  6. Confirm info bar is shown

Scenario 2:

  1. Install 1.10.97
  2. Leave sync flag as Default (sync is disabled)
  3. Restart, dismiss default browser bar
  4. Update to 1.11.x
  5. Confirm no info bar is shown

Scenario 3:

  1. Install 1.10.97
  2. Set sync flag to Disabled
  3. Restart, dismiss default browser bar
  4. Update to 1.11.x
  5. Confirm no info bar is shown

Scenario 4:

  1. Install 1.10.97
  2. Set sync flag to Enabled
  3. Restart, dismiss default browser bar
  4. Set up sync chain
  5. Set sync flag to Disabled
  6. Restart browser.
  7. Update to 1.11.x
  8. Confirm no info bar is shown

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment