Adding support for Acknowledge, Beacons, Data and MAC commands #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
reviewed
Mar 28, 2019
There was a problem hiding this comment.
Thank you @blueluna! I don't have the standard, and I don't have any hardware running other implementations of the protocol, so my ability to review and test this is limited. Still, I've looked over the code and left some comments.
Let me know what you think about the comments. Once they have been resolved, I'm happy to merge.
Co-Authored-By: blueluna <[email protected]>
- Added more test cases for encoding and decoding Beacon - Fixed documentation for hopping sequence duplication
|
Okay, this looks good to merge. Thank you again, @blueluna! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for encoding and decoding Beacons and MAC commands. This is my first time working with 802.15.4 so I might not understand all the concepts. But here goes.
There probably are opportunities for better naming in some part of the code (for example FrameContent?).
Testing done.
I have decoded
Acknowledge,Beacon,Command::AssociationRequest,Command::AssociationResponse,Command::BeaconRequest,Command::DataRequest,Datafrom a coordinator or other devices in a PAN. I have encodedCommand::AssociationRequest,Command::BeaconRequest,Command::DataRequestwhich has been understood (I believe) by a coordinator.