feat(fscomponents): Add image counter, new style options to ZoomCarousel #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new option that can be rendered: image counter --Absolutely placed component with custom rendering or custom styles as props - Added new prop options for the carousel and image containers - changed the default container styling to be flex friendly, fixing an issue where thumbnails would overflow beyond parent boundaries
bweissbart
requested changes
Mar 23, 2020
| */ | ||
| fillContainerStyle?: StyleProp<ViewStyle>; | ||
| carouselContainerStyle?: StyleProp<ViewStyle>; |
There was a problem hiding this comment.
It doesn't look like this is used anywhere.
There was a problem hiding this comment.
bweissbart
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--Absolutely placed component with custom rendering or custom styles as props
Added some storybook options and also tested as a linked package inside of a test app.