feat(fscomponents): Add styling and prop options to ZoomCarousel #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Add prop to hide page indicators -Fix issue where if fillContainer is set to true and showThumbnails is set to true, thumbnails won't show -Add prop for custom styling for the fillContainer prop -Add two stories to the storybook showing fillContainer prop for ZoomCarousel
bweissbart
requested changes
Mar 18, 2020
packages/fscomponents/src/components/ZoomCarousel/ZoomCarousel.web.tsx
Outdated
Show resolved
Hide resolved
- revert a change to remove react native stylesheet from a html div - add back in fillContainerStyle that was mistankingly ommitted
bweissbart
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add prop to hide page indicators
-Fix issue where if fillContainer is set to true and showThumbnails is set to true, thumbnails won't show
-Add prop for custom styling for the fillContainer prop
-Add two stories to the storybook showing fillContainer prop for ZoomCarousel