Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build warns, errors #112

Closed
ctzurcanu opened this issue Jun 17, 2015 · 5 comments
Closed

build warns, errors #112

ctzurcanu opened this issue Jun 17, 2015 · 5 comments

Comments

@ctzurcanu
Copy link

...
node_modules/.bin/jison src/grammar.jison -o build/grammar.js.tmp
# After building the grammar, run it through the uglifyjs to fix some non-strict issues.
# Until https://github.com/zaach/jison/issues/285 is fixed, we must do this to create valid non-minified code.
node_modules/.bin/uglifyjs \
        build/grammar.js.tmp -o build/grammar.js \
        --comments all --compress --beautify
WARN: Dropping unreachable code [build/grammar.js.tmp:88,0]
...

jspp src/diagram.js > build/diagram-grammar.js || (rm build/diagram-grammar.js && exit 127)
/bin/sh: jspp: command not found

have tried npm install JSPP -g but no fix

solutions?

@bramp
Copy link
Owner

bramp commented Jun 17, 2015

Hey @ctzurcanu you need to sudo gem install jspp, instructions available https://github.com/bramp/js-sequence-diagrams#build-requirements

@bramp bramp closed this as completed Jun 17, 2015
@ctzurcanu
Copy link
Author

I'm sorry I did not read that with more attention. It built.

@bramp
Copy link
Owner

bramp commented Jun 17, 2015

No problem. I've created #113 to alert you (with instructions on how to fix) if jspp is missing.

@bramp
Copy link
Owner

bramp commented Jun 18, 2015

In fact, I found a way to get rid of jspp, and use a standard npm tools. Meaning Make will just install everything it needs. 73b6dc8

@ctzurcanu
Copy link
Author

kudos! I will try to modify your lib to use svg.js instead of raphael. hope to bring you the good news soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants