Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scripts to simplify code base as much as possible #219

Open
Tracked by #224
adamltyson opened this issue Sep 19, 2023 · 2 comments
Open
Tracked by #224

Refactor scripts to simplify code base as much as possible #219

adamltyson opened this issue Sep 19, 2023 · 2 comments
Labels
atlasgen Issue was transferred from the retired bg-atlasgen. Concerns the atlas_generation submodule.

Comments

@adamltyson
Copy link
Member

No description provided.

@viktorpm
Copy link
Contributor

Loading annotations and references should be independent of mesh generation

@willGraham01
Copy link
Collaborator

willGraham01 commented Feb 14, 2024

Also going to bump this - most of the atlas generation scripts themselves follow the same pattern: get template, structure heirachy, wrap up. In the majority of cases these are identical save for the input data and file paths, etc.

It wouldn't be unfeasible to create an atlas generation base class, rather than a folder of scripts (or at least, a set of general purpose functions).

Then this repeated, general functionality can go in the base class/functions, and atlases can be added either as instances (setting appropriate class member values like file location, etc) or a derived class (in the event that certain steps genuinely need to be edited from the standard workflow).

@willGraham01 willGraham01 added the atlasgen Issue was transferred from the retired bg-atlasgen. Concerns the atlas_generation submodule. label Feb 23, 2024
@willGraham01 willGraham01 transferred this issue from brainglobe/bg-atlasgen Feb 23, 2024
@alessandrofelder alessandrofelder mentioned this issue Jul 22, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atlasgen Issue was transferred from the retired bg-atlasgen. Concerns the atlas_generation submodule.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants