Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brainflow BA_v4 integration #730

Merged

Conversation

Sarthak031
Copy link
Contributor

No description provided.

@Andrey1994
Copy link
Member

I think macos job is failed because they've removed macos 11 runners frim github and its for entire repo, this issue with manylinux does not look related to your changes either, so you can ignore it, I fill fix in master branch

Copy link
Member

@Andrey1994 Andrey1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix CI issues in master branch, the main problem here is wrong buffer size and packet_id other comments are more like minor refactoring

src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
src/board_controller/brainflow_boards.cpp Outdated Show resolved Hide resolved
@Sarthak031 Sarthak031 requested a review from Andrey1994 July 2, 2024 10:04
src/board_controller/brainflow_boards.cpp Outdated Show resolved Hide resolved
src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
src/board_controller/brainalive/brainalive.cpp Outdated Show resolved Hide resolved
@Andrey1994 Andrey1994 merged commit a0b554d into brainflow-dev:master Jul 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants