Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable voice support in xmake #544

Closed
Commandcracker opened this issue Nov 2, 2022 · 5 comments
Closed

Disable voice support in xmake #544

Commandcracker opened this issue Nov 2, 2022 · 5 comments
Assignees
@Bricklou
Labels
enhancement New feature or request

Comments

@Commandcracker
Copy link

Commandcracker commented Nov 2, 2022 •
edited
Loading

Is there some way to disable voice support when building with xmake, like in cmake BUILD_VOICE_SUPPORT
@Bricklou
Copy link
Contributor

Bricklou commented Nov 3, 2022

Hi,
I'm the maintainer of the xmake package of DPP.
There is no way to disable the voice support, but I can take a look to add it. Don't hesitate to suggest something if you find how to do that.

@braindigitalis braindigitalis added the enhancement New feature or request label Nov 3, 2022
@Commandcracker
Copy link
Author

This might help: xmake_configuration_option.

$ xrepo info dpp
Screenshot_20221103_132221
Setting some compiler flag cud also be a solution, but it would be easier for the end user with an configuration_option.

@SirObby
Copy link
Contributor

SirObby commented Nov 3, 2022

Seems like it would be possible.

@Bricklou
Copy link
Contributor

Bricklou commented Nov 3, 2022

I made the change, i'm waiting for my PR to be approved: xmake-io/xmake-repo#1596

@Bricklou
Copy link
Contributor

Bricklou commented Nov 4, 2022

The PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bricklou Bricklou

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@braindigitalis @Bricklou @Commandcracker @SirObby