Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension for Quaternions.jl #31

Merged
merged 17 commits into from
Nov 12, 2024
Merged

Extension for Quaternions.jl #31

merged 17 commits into from
Nov 12, 2024

Conversation

brainandforce
Copy link
Owner

@brainandforce brainandforce commented Nov 11, 2024

This allows for construction, conversion, and promotion between Quaternion and AbstractCliffordNumber{VGA(3)} instances: Quaternion{T} is treated as effectively identical to EvenCliffordNumber{VGA(3),T,4}.

Promotion preserves CliffordNumbers.jl semantics, so any promotion involving both Quaternion and AbstractCliffordNumber{VGA(3)} will return an AbstractCliffordNumber{VGA(3)}.

The Quaternions.jl slerp implementation is defined for AbstractCliffordNumber arguments, but in the future CliffordNumbers.jl may provide its own slerp implementation for arbitrary algebras.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (dda14d2) to head (8af09ab).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   89.40%   89.78%   +0.37%     
==========================================
  Files          23       24       +1     
  Lines         840      871      +31     
==========================================
+ Hits          751      782      +31     
  Misses         89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brainandforce brainandforce force-pushed the ext/quaternions branch 4 times, most recently from 8b011ab to 8714c05 Compare November 12, 2024 20:06
@brainandforce
Copy link
Owner Author

wow this took forever

@brainandforce brainandforce merged commit 31148ed into main Nov 12, 2024
6 checks passed
@brainandforce brainandforce deleted the ext/quaternions branch November 12, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant