-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension for Quaternions.jl #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uction/conversion
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 89.40% 89.78% +0.37%
==========================================
Files 23 24 +1
Lines 840 871 +31
==========================================
+ Hits 751 782 +31
Misses 89 89 ☔ View full report in Codecov by Sentry. |
brainandforce
force-pushed
the
ext/quaternions
branch
4 times, most recently
from
November 12, 2024 20:06
8b011ab
to
8714c05
Compare
brainandforce
force-pushed
the
ext/quaternions
branch
from
November 12, 2024 20:22
8714c05
to
6115195
Compare
brainandforce
force-pushed
the
ext/quaternions
branch
from
November 12, 2024 20:52
b01fb0c
to
9290e59
Compare
wow this took forever |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for construction, conversion, and promotion between
Quaternion
andAbstractCliffordNumber{VGA(3)}
instances:Quaternion{T}
is treated as effectively identical toEvenCliffordNumber{VGA(3),T,4}
.Promotion preserves CliffordNumbers.jl semantics, so any promotion involving both
Quaternion
andAbstractCliffordNumber{VGA(3)}
will return anAbstractCliffordNumber{VGA(3)}
.The Quaternions.jl
slerp
implementation is defined forAbstractCliffordNumber
arguments, but in the future CliffordNumbers.jl may provide its ownslerp
implementation for arbitrary algebras.