Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the iteration scheme in CliffordNumbers.mul for performance #12

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

brainandforce
Copy link
Owner

There is a significant discrepancy in performance on hardware with SIMD if two differently-sized arguments are multliplied in reverse order: in general, larger first arguments result in slower runtimes because there are more loop iterations as opposed to vectorized operations. This change generates the syntax tree differently depending on argument size.

Perhaps in the future we can come up with a heuristic to optimize code generation even further. Additionally, I want to unify the cases so we don't have a lot of boilerplate code.

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (fce1003) to head (b6af29b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   84.19%   85.37%   +1.17%     
==========================================
  Files          14       14              
  Lines         696      711      +15     
==========================================
+ Hits          586      607      +21     
+ Misses        110      104       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brainandforce brainandforce merged commit 536f8e4 into main Jun 1, 2024
6 checks passed
@brainandforce brainandforce deleted the refactor/multiply-kernel branch June 1, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant