Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send requests using proxied user agent #34

Open
bradleyjkemp opened this issue Jul 3, 2019 · 1 comment
Open

Send requests using proxied user agent #34

bradleyjkemp opened this issue Jul 3, 2019 · 1 comment
Labels
grpc-proxy grpc-replay

Comments

@bradleyjkemp
Copy link
Owner

The upgrade to grpc-go (#33) broke failed the integration tests because the user agent changed.
This shouldn't happen because grpc-replay should send the user agent from the dump instead of its own default user agent.

I think the same issue will apply to grpc-proxy
@bradleyjkemp
Copy link
Owner Author

bradleyjkemp commented Jul 17, 2019 •
edited
Loading

Interestingly this isn't currently possible: the "user-agent" header is reserved by the Go gRPC implementation and doesn't let you set it directly (it will always append "grpc-go/<version>" to any string you provide to WithUserAgent).

This is definitely going to break use cases where the server behaves differently based on the user agent but I'm currently not sure how to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
grpc-proxy grpc-replay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradleyjkemp