[CLOSED] Fix fontSizeChange event for Restore Font Size command

[core-ai-bot]

Issue by lkcampbell
Tuesday Apr 08, 2014 at 01:37 GMT
Originally opened as adobe/brackets#7443

---

Some of the recent changes to font size adjustment broke the fontSizeChange event when the Restore Font Size command is used. This fix makes the event fire correctly again.

---

lkcampbell included the following code: https://github.com/adobe/brackets/pull/7443/commits

[core-ai-bot]

Comment by TomMalbran
Tuesday Apr 08, 2014 at 02:17 GMT

---

@lkcampbell Thanks for fixing this. I am a bit busy these days.

[core-ai-bot]

Comment by lkcampbell
Tuesday Apr 08, 2014 at 02:29 GMT

---

Sorry guys, let me fix it. I was wondering why it seemed to be firing off twice. @RaymondLim's way looks much better than mine.

[core-ai-bot]

Comment by lkcampbell
Tuesday Apr 08, 2014 at 04:15 GMT

---

@RaymondLim and@TomMalbran, code review changes committed.

[core-ai-bot]

Comment by lkcampbell
Tuesday Apr 08, 2014 at 15:26 GMT

---

@RaymondLim and@TomMalbran, Code Review notes reviewed. Nothing to change in the code as far as I can tell.

[core-ai-bot]

Comment by lkcampbell
Tuesday Apr 08, 2014 at 15:39 GMT

---

@RaymondLim and@TomMalbran, hold off for a bit. I have one more thing I want to test. I will let you know when I am done.

[core-ai-bot]

Comment by lkcampbell
Tuesday Apr 08, 2014 at 15:52 GMT

---

@RaymondLim and@TomMalbran, almost missed a critical little detail :). Code ready for next code review.

[core-ai-bot]

Comment by lkcampbell
Tuesday Apr 08, 2014 at 16:22 GMT

---

Making a note here to remind myself. I need to put in some Unit Tests for this event in the near future so we don't have any future regressions.

[core-ai-bot]

Comment by RaymondLim
Tuesday Apr 08, 2014 at 23:08 GMT

---

Looks good. Merging.