Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] [BezierEditor] Fix fadeout issue #6549

Open
core-ai-bot opened this issue Aug 30, 2021 · 5 comments
Open

[CLOSED] [BezierEditor] Fix fadeout issue #6549

core-ai-bot opened this issue Aug 30, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by MarcelGerber
Wednesday Mar 19, 2014 at 14:03 GMT
Originally opened as adobe/brackets#7248


Steps to reproduce the issue, introduced by #7235:

  1. Start an Inline Timing Function Editor
  2. Make the function invalid, like cubic-bezier(1.000001, 0, 0, 0)
  3. Make it valid again
  4. Make some other valid changes (like deleting the additional zeros) while the fadeout is still running

Result: The hint is immediately hidden
Expected: The fadeout should continue

This PR makes the code a bit cleaner (using editor.hint object for everything that has to do with the hint) and uses .hide(), suggested by@zaggino.


MarcelGerber included the following code: https://github.com/adobe/brackets/pull/7248/commits

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Mar 19, 2014 at 15:16 GMT


@SAPlayer I could review pull requests faster if the branch names weren't so long :)

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Wednesday Mar 19, 2014 at 15:28 GMT


@redmunds I'll try to use a shorter one next time ;)

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Mar 19, 2014 at 18:25 GMT


@redmunds Try https://github.com/defunkt/hub - then you can do things like hub checkout https://github.com/adobe/brackets/pull/7248

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Mar 19, 2014 at 20:14 GMT


I always just copy-paste the branch name from the top of the PR into the terminal, personally :-) Or you can click the "command line" link at bottom (next to the merge button) and copy the full command line to the clipboard in 1 click...

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Friday Mar 21, 2014 at 19:42 GMT


Looks good. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant