-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Show icon indicating extension in Extension Manager is available for update #6100
Comments
Comment by lkcampbell +1 on this. Good idea. |
Comment by lkcampbell If |
Comment by peterflynn Yep, definitely. We've talked about this a bunch but I don't think there's any bug or backlog item tracking it yet (other than the "full" extension updates story). We can presumably reuse the green-circle overlay from the Extension Manager dialog, so I'm not sure we need any additional icons. I think we've talked about doing a once per 24-hrs ping to check for updates, similar to how we check for Brackets updates. We should probably double check with |
Comment by lkcampbell
|
Comment by larz0
https://f.cloud.github.com/assets/1495261/1467328/8b0bf01e-4580-11e3-8700-b94a6805eba9.png It's relatively smaller than the update count on the tab so that people won't notice it while they're focusing on work. |
Comment by peterflynn
|
Comment by larz0
|
Comment by ingorichter Why can't we change the color of the icon in a subtle way? Make the icon glow and add a halo to it. |
Comment by larz0 I actually don't mind the entire icon being green when there are updates. |
Comment by dangoor Hey |
Comment by lkcampbell
|
Comment by peterflynn Yay! |
Comment by AllThingsSmitty Fantastic! |
Comment by lkcampbell Okay, I finally had some time to make progress on this but there are still a few design issues I would like feedback on before I commit the PR. The icon turns green when updates are available. The green is the same color as the green circle background in the update count in the Extension Manager. The code checks the extension registry every 24 hours, assuming the icon has not already been turned green. If there are one or more updates available for installed extensions, the icon is turned green. This icon stays green until the Extension Manager is opened (via the icon or the menu entry or whatever). The moment the Extension Manager is opened, the icon changes back to light gray; its job is done at this point. Whatever the user decides to do once the Extension Manager is opened does not affect the icon in any way. For example, if the user opens the Extension Manager, looks at the updates available, and decides to update some, all, or none of the extensions, the icon will still remain light gray in all cases. After 24 hours, the cycle restarts. Let me know if you have any concerns or suggestions. Otherwise, this is the design of the PR I am committing in the next day or two. |
Comment by larz0 So if I don't decide to update right now the icon will turn green after 24 hours right? If that's the case then it's pretty cool. |
Comment by lkcampbell
|
Comment by peterflynn That seems like it could feel a little weird: I open Extension Manager but don't accept all updates, and the icon goes gray -- so my mental model is "ah, it's like an 'unread' indicator, so it remembers which ones I've chosen to ignore." Then the icon turns green at some seemingly-arbitrary later point, yet there are no additional updates available -- it seems to have forgotten which ones I already saw. So I think it'd be better if we either keep it green whenever a nonzero number of updates is still available, or actually do remember which were already "seen." The former seems simpler to implement, although it might argue for a subtler visual indicator since it's more likely to hang around longer. I'll defer to |
Comment by dangoor Remembering which were seen is not likely to be too difficult. Something like:
The array would also need to be updated every time the user updates an extension. I'd personally be quite happy with a UX like that: an indicator whenever there's an update that I haven't seen before. |
Comment by lkcampbell Okay, thanks for the input. I will start working on an improved implementation. |
Comment by larz0 Guys, I made the green circle larger than what I posted originally. We can use CSS to hide the green circle on the SVG icon (here it is: http://cl.ly/0R341g3W090s) |
Comment by lkcampbell
What do you think of it as an alternative? |
Comment by AllThingsSmitty
|
Comment by larz0 I like it too. Some people prefer a quieter indicator so I provided one just in case. |
Comment by njx Sorry to jump in late, and I don't want to derail the current implementation, but is there a reason we can't just badge it persistently with the number of extensions that have available updates? Do we feel like it's going to be common for people to want to ignore updates? |
Comment by larz0 I don't see why people would ignore updates as they're supposed to make things better. I did some test on showing update count on the icon and I don't recommend it. |
Comment by TomMalbran What would happen if there are extensions that have updates but can't be updated because they need a newer version of Brackets? In this case the user would avoid those updates but would want to update them once they upgrade Brackets. (It usually happens when an extension updates to support the next release of Brackets before Brackets is released). Maybe we could not count these updates? |
Comment by dangoor
|
Comment by MarcelGerber
|
Comment by TomMalbran Yes, I don't think it should be counted on either of the places. So we should change the behavior of the update badge on the Installed tab. |
Comment by lkcampbell Just now catching up on the discussion. I agree with |
Issue by AllThingsSmitty
Friday Jan 31, 2014 at 18:47 GMT
Originally opened as adobe/brackets#6723
If you open Extension Manager in Brackets the "Installed" icon will indicate if an update is available for extensions. It would be good to see the same call-to-action icon (green circle) used on Extension Manager icon (below the Live Preview icon) so a user knows one is available there.
The text was updated successfully, but these errors were encountered: