Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Mac: Crash when quitting Chrome running dev tools connected to Brackets #5389

Open
core-ai-bot opened this issue Aug 30, 2021 · 9 comments

Comments

@core-ai-bot
Copy link
Member

Issue by njx
Thursday Nov 07, 2013 at 22:36 GMT
Originally opened as adobe/brackets#5893


This is on 10.9.

  1. Run Brackets on Mac with Chrome open
  2. Debug > Show Developer Tools - this brings them up in a separate Chrome instance
  3. Quit the new Chrome instance

Result: Brackets crashes.

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Nov 07, 2013 at 22:37 GMT


Not sure if you need to already have Chrome running in step 1. But in step 2, it seems like we shouldn't bring dev tools up in a separate Chrome instance--we should only do that in live development. Either way, though, it shouldn't crash Brackets :)

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Nov 07, 2013 at 22:38 GMT


High priority to@redmunds, /cc@fungl164

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Nov 07, 2013 at 22:38 GMT


Tagging sprint 34.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday Nov 07, 2013 at 22:40 GMT


I got crash on my 10.8.5 also. So I think this is on all mac.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday Nov 07, 2013 at 23:23 GMT


@fungl164 I'm also seeing this on Mac 10.8. I tried switching back to using default profile for Dev Tools (which is something we want to do to be consistent with Windows), but that didn't fix crash.

@core-ai-bot
Copy link
Member Author

Comment by fungl164
Friday Nov 08, 2013 at 00:24 GMT


Ok. I'll take a look when I get home tonight.

@core-ai-bot
Copy link
Member Author

Comment by fungl164
Friday Nov 08, 2013 at 06:11 GMT


Ok guys, I think I found the likely source for the crash. Here's the fix. (see adobe/brackets-shell#373)

Let me know how it goes. Best.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Friday Nov 08, 2013 at 16:01 GMT


FBNC back to@njx

@core-ai-bot
Copy link
Member Author

Comment by njx
Saturday Nov 09, 2013 at 01:25 GMT


Hmmm. Immediately after pulling the shell change and recompiling, I got into a weird state where Brackets wasn't opening dev tools at all, or seemed to be opening it in such a way that the Chrome window wasn't visible. But after quitting and restarting Brackets a few times it seems to be working. I'm going to close this for now and will file a new bug if I encounter that weird behavior again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant