Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] [Core][Live Preview]: It will pop up Live Preview Error dialog if launch live preview with an image. #5263

Open
core-ai-bot opened this issue Aug 30, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by julieyuan
Tuesday Oct 29, 2013 at 06:07 GMT
Originally opened as adobe/brackets#5741


Steps:

  1. Launch Brackets and open the default sample folder.
  2. Open the image quick-edit.png from the screenshots folder.
  3. Click live preview icon on the right sidebar.(It will pop up an error dialog and preview index.html in Chrome)
  4. Close the error dialog
  5. Close the webpage from Chrome.

Results:
At step3, it pops up Live Preview Error dialog and shows the message "Unable to load Live Development page". But the index.html page is opened and previewing in Chrome. But the live preview icon doesn't change to orange.
At step5, the live preview icon will show the tooltip.

Expected:
This dialog should not appear and the live preview icon should show as connected status.

ENV: MAC 10.8 and Win8.1 English OS
Build: 0.33.0-10155

Snapshots:
Please refer to snapshot for details:
Step3:
2222
Step5:
555

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Tuesday Oct 29, 2013 at 12:48 GMT


This only happens when the Working Files are not empty.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Tuesday Oct 29, 2013 at 13:24 GMT


It is caused by returning null by _getCurrentDocument() on line 571. Should we better use the return value of _getInitialDocFromCurrent?

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Nov 04, 2013 at 19:17 GMT


Medium priority to@couzteau who is reviewing@SAPlayer's fix.

@core-ai-bot
Copy link
Member Author

Comment by julieyuan
Wednesday Nov 06, 2013 at 02:27 GMT


This issue is fixed in build 0.34.0-10270. Thanks and closing it. Here is snapshot for reference:
screen shot 2013-11-05 at 6 25 03 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant