Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] fix 5705 - Cleanup for Peter's belated drive by comments #5237

Open
core-ai-bot opened this issue Aug 30, 2021 · 6 comments
Open

[CLOSED] fix 5705 - Cleanup for Peter's belated drive by comments #5237

core-ai-bot opened this issue Aug 30, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by couzteau
Saturday Oct 26, 2013 at 02:52 GMT
Originally opened as adobe/brackets#5710


fix #5705: Image closed and no editor opened after if cancel quitting or closing project

Also fixes handleFileClose(imageFilePath) with image file path.


couzteau included the following code: https://github.com/adobe/brackets/pull/5710/commits

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Saturday Oct 26, 2013 at 18:44 GMT


@couzteau It doesn't fix #5705 yet even after I clean up all the JSLint errors in your branch. I didn't get a prompt to save my changes in a text file; Brackets just quit.

@core-ai-bot
Copy link
Member Author

Comment by couzteau
Saturday Oct 26, 2013 at 19:07 GMT


sorry about jslint. fixed. Prompt for unsaved changes on quit works fine for me.

@core-ai-bot
Copy link
Member Author

Comment by couzteau
Saturday Oct 26, 2013 at 19:13 GMT


but i didnt have time to fully test everything - so please hold off

@core-ai-bot
Copy link
Member Author

Comment by couzteau
Monday Oct 28, 2013 at 21:26 GMT


@RaymondLim I simplified the paths through the if statements. I hope this is it, finally. THANK YOU!

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Monday Oct 28, 2013 at 22:25 GMT


Looks good. Merging.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Tuesday Oct 29, 2013 at 21:07 GMT


@couzteau Thanks for fixing these so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant