Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] "close others" extension added to default extensions directory. #4246

Open
core-ai-bot opened this issue Aug 29, 2021 · 30 comments
Open

[CLOSED] "close others" extension added to default extensions directory. #4246

core-ai-bot opened this issue Aug 29, 2021 · 30 comments

Comments

@core-ai-bot
Copy link
Member

Issue by sathyamoorthi
Sunday Jul 28, 2013 at 16:46 GMT
Originally opened as adobe/brackets#4590

adobe/brackets#4469

sathyamoorthi included the following code: https://github.com/adobe/brackets/pull/4590/commits
@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Monday Jul 29, 2013 at 01:32 GMT

I got three warnings in "Travis Build" and notified as Failed. I gave proper pull request. But i don't know the reason for Failure. Can anybody help me in this to proceed further?

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday Jul 29, 2013 at 03:39 GMT

@sathyamoorthi I've been getting those warnings as well. I'll mention it tomorrow.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Monday Jul 29, 2013 at 04:36 GMT

@larz0 ahhh. Thank you. I am not an expert in Github. I created this PR because i got this same error in my old PR. When i got "Travis" warnings again here, i was totally blank. Thank god, you gave positive reply.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Monday Jul 29, 2013 at 22:16 GMT

@sathyamoorthi There was a change to jsHint that is causing all builds to fail. We have a fix that will go in once we have sprint 28 wrapped up and delivered.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Tuesday Jul 30, 2013 at 06:09 GMT

@JeffryBooher small bug in this pull request. Let me update this on next commit.

Image

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Wednesday Jul 31, 2013 at 07:06 GMT

@JeffryBooher,@TomMalbran committed new set of changes that you both mentioned. Still, i am expecting some more changes after your review. So i didn't add comments to functions that i have added in the core. Once, everything finalized we can add function headers.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Sunday Aug 25, 2013 at 02:23 GMT

@sathyamoorthi are you still working on this?

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Sunday Aug 25, 2013 at 02:35 GMT

@JeffryBooher yes. i committed changes that you have mentioned. i'm waiting for your review.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Sunday Aug 25, 2013 at 03:14 GMT

Done with review. Just a couple of minor naming nits and this is ready to merge. Good Job!

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Sunday Aug 25, 2013 at 04:28 GMT

@JeffryBooher changed those function names.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Aug 27, 2013 at 16:58 GMT

Can you merge master into this branch? There are quite a number of unit-test failures that I don't understand. I'm hoping that merging master into the branch fixes most of them.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Saturday Aug 31, 2013 at 02:26 GMT

@JeffryBooher any more changes needed?

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Saturday Aug 31, 2013 at 02:29 GMT

@sathyamoorthi I haven't had time the past few days to look at it since we've been closing down Sprint 30. I'll look at it over the weekend.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Saturday Aug 31, 2013 at 02:41 GMT

@JeffryBooher sure.np.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Sep 03, 2013 at 16:55 GMT

The code looks great.

There are a few unit test failures that you need to fix plus you need unit tests for close others, close above, and close below.

I'd start by merging master into your branch. I think there are some failures that may be due to the fact that you're out of date with the current shell plus some others that have been fixed in master.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Saturday Sep 07, 2013 at 03:38 GMT

How to run tests? I ran SpecRunner.html. But i am getting errors.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Saturday Sep 07, 2013 at 03:59 GMT

Debug -> Run Tests. From Brackets using the Github code.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Saturday Sep 07, 2013 at 05:08 GMT

I tried. I am seeing a new window with menus for testing. Nothing on he content area. It is white. I clicked "Show developer tools", nothing happened. I don't know what to do. I copied github source into sprint30 folder and ran Sprint30.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Saturday Sep 07, 2013 at 05:49 GMT

@sathyamoorthi can you post a screen capture of what you're seeing? You might want to just merge master into your branch, install sprint 30 build then hold down the shift key and double click the brackets sprint 30 icon to start it and prompt for the source, then select your github brackets folder src/index.html to start. It should find the test/ folder which is what it's looking for. It shouldn't be a blank window.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Saturday Sep 07, 2013 at 06:36 GMT

@JeffryBooher I did exactly the same what you said. I am getting below screen while i run test.

Image

I click all menus, but it shows nothing. When i run test, i'm not able to close this window or brackets. I am killing process to close Brackets. So i went to console, i'm seeing these errors.

Image

I get these errors only, when i boot Brackets from Github source. Does this work for you?

@core-ai-bot
Copy link
Member Author

Comment by lkcampbell
Saturday Sep 07, 2013 at 14:14 GMT

@sathyamoorthi, it looks like there is a problem with some of your third party modules in your default extensions folder. Go to the some of the directories that are popping up in your log. Are they missing or empty?

Try the following git commands on your local brackets repo:

git submodule sync
git submodule update --init --recursive

That might update the third party modules regardless of the problem

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Saturday Sep 07, 2013 at 16:19 GMT

@lkcampbell It works, thanks. Actually, i directly downloaded source as zip and used. But now i boot directly from my local clone and it works.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Saturday Sep 07, 2013 at 17:47 GMT

@JeffryBooher I merged master into this branch. No unit test fails. But there are fails on integration test. I'm digging into it. Let me know, if you have other thoughts.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Saturday Sep 07, 2013 at 23:04 GMT

@sathyamoorthi You probably can just add the new ones for close above / below / others and I can take a look and see why the others were failing.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Sunday Sep 08, 2013 at 15:40 GMT

@JeffryBooher Ok. super. let me work on that.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Wednesday Sep 11, 2013 at 17:30 GMT

@JeffryBooher I have added unit tests for close others, above and below. Please take a look.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Sep 17, 2013 at 23:55 GMT

@sathyamoorthi looks like you forgot to add the "unittest-files" folder and the unit test files to your pull request :)

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Wednesday Sep 18, 2013 at 04:58 GMT

@JeffryBooher Hi. Actually unittest-files folder don't have any content. Files will be created at run time inside that folder and will be deleted once everything finished well. So, to commit that folder i have added a dummy file.

And i'm seeing lot of integration test failures. I'm not sure whether i broke anything by modifying DocumentCommandHandlers and DocumentManager.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Sep 18, 2013 at 05:20 GMT

@sathyamoorthi you might want to merge master into your branch snd see if that fixes the test failures.

@core-ai-bot
Copy link
Member Author

Comment by sathyamoorthi
Wednesday Sep 18, 2013 at 05:22 GMT

@JeffryBooher I merged master into my branch. But still i see failures. Meanwhile, no errors when i run tests directly on Master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot