[CLOSED] Add link to google JSLint Error

[core-ai-bot]

Issue by drewhamlett
Friday Mar 22, 2013 at 21:35 GMT
Originally opened as adobe/brackets#3227

---

adobe/brackets#3131

May need a little more discussion completing the issue but this is a start.

---

drewhamlett included the following code: https://github.com/adobe/brackets/pull/3227/commits

[core-ai-bot]

Comment by redmunds
Friday Mar 22, 2013 at 22:21 GMT

---

FYI, the JSLint functionality is currently be re-factored out of Brackets core and into an extension in pull request adobe/brackets#3143, so this change will have to be co-ordinated with that one.

[core-ai-bot]

Comment by DennisKehrig
Saturday Mar 23, 2013 at 10:44 GMT

---

Looks like this would be easy to re-integrate after #3143 has landed, just modify extensions/default/JSLint/main.js as you modified language/JSLintUtils.js now.

[core-ai-bot]

Comment by TomMalbran
Saturday Mar 23, 2013 at 11:10 GMT

---

Not completely the same, since the new extension uses a template and event delegation, so the link should be added to the template and the event, can be added as if inside the click event on the table (you can get the reason from the table content) or one event for each link.

I think that Search instead of Google might be better and could be added to the strings. Anyway, a better solution to #3131 might be just to add:

cursor: auto;
-webkit-user-select: text;
-khtml-user-select: text;
-moz-user-select: text;
-ms-user-select: text;
-o-user-select: text;
user-select: text;

To each cell, in the css inside the extension.

[core-ai-bot]

Comment by drewhamlett
Saturday Mar 23, 2013 at 20:34 GMT

---

@TomMalbran The user-select mode may not work like you would expect in this situation. It may need a little more thought if you do something like that. That's what I was originally had, but someone on chat suggested the auto search. Can't remember his name though.

I like the template and event binding. After using angular js for so long it felt so wrong(and weird) adding that little bit of code and click event. Haha

[core-ai-bot]

Comment by TomMalbran
Saturday Mar 23, 2013 at 22:32 GMT

---

You are right, I tested it and it didn't work, not sure why thought. I guess that a search isn't that bad then, it is even what you usually want to do when copying it anyway.

Most of this jQuery things were done before adding Mustache as the template system, and where not changed. I also find it wrong to be making a whole template like this, so I've been changing most to use Mustache instead.

[core-ai-bot]

Comment by DennisKehrig
Friday Mar 29, 2013 at 13:14 GMT

---

#3143 is in, so this could now be revisited

[core-ai-bot]

Comment by drewhamlett
Sunday Mar 31, 2013 at 21:06 GMT

---

adobe/brackets#3304

[core-ai-bot]

Comment by adrocknaphobia
Tuesday Apr 16, 2013 at 21:51 GMT

---

FYI. We may want to consider linking to this site (or pulling in their data).
http://jslinterrors.com

[core-ai-bot]

Comment by njx
Tuesday Apr 16, 2013 at 21:52 GMT

---

Closing -- looks like #3304 supersedes this.