[CLOSED] Fix #3094: Refactor JSLint into an extension

[core-ai-bot]

Issue by TomMalbran
Friday Mar 15, 2013 at 03:14 GMT
Originally opened as adobe/brackets#3143

---

This request fixes the issue #3094 by refactoring JSLint into an extension. I also did several changes in JSLintUtils, now being the main file in the extension as a result of the refactor, to use a template for the table and use Language to identify JavaScript files instead of the extension. I was also able to move the JSLint submodule to the extension.

Note 1: I had to touch my git files to move the submodule, so not sure if that will work when merged.
Note 2: Not sure why it didn't renamed JSLintUtils to main and show the differences.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/3143/commits

[core-ai-bot]

Comment by DennisKehrig
Tuesday Mar 19, 2013 at 16:48 GMT

---

Awesome, I'll get to to this later this week!

[core-ai-bot]

Comment by TomMalbran
Wednesday Mar 20, 2013 at 08:19 GMT

---

The submodule movement didn't work as I expected and was giving me lots of problem over the last merge. It also didn't made much sense, since this is now an extensions and could be removed. Any other extension uses submodules to load the thirdparty code, so I decided to just remove the submodule and add the files to the branch. I hope that is ok.

I fixed the merge issues and fixed a few other things.

I also changed the path in the NOTICE. I haven't move it around so that the differences aren't much, but I could do if needed.

[core-ai-bot]

Comment by DennisKehrig
Friday Mar 22, 2013 at 17:05 GMT

---

Reviewing.

[core-ai-bot]

Comment by DennisKehrig
Friday Mar 22, 2013 at 19:28 GMT

---

JSLint isn't used by other extensions, it seems, so moving it is not a problem.

@TomMalbran: "Any other extension uses submodules to load the thirdparty code" - how do you mean that? To my knowledge, the only extension that uses Git submodules is "Continuous Compilation". Ironically (and luckily) for JSLint :)

[core-ai-bot]

Comment by DennisKehrig
Friday Mar 22, 2013 at 20:10 GMT

---

@TomMalbran Great work! Works right away, and doesn't break any unit tests.

Please fix the minor issues mentioned above and merge with master again, then I'll run the unit tests again and merge it. Thank you so much!

[core-ai-bot]

Comment by njx
Friday Mar 22, 2013 at 21:05 GMT

---

Hey there--please hold off on merging this since today is the last day of the sprint and we're trying to close it down. We can merge it next week. Thanks.

[core-ai-bot]

Comment by TomMalbran
Saturday Mar 23, 2013 at 01:40 GMT

---

What I meant before, is that every default extension that uses thirdparty modules, doesn't uses in a submodule way. The files are just included in the thirdparty folder.

I haven't checked any other extension before. I also didn't thought that it could be possible to add the submodule directly in the extension folder as the "Continuous compilation did". I will check into that, might be nicer to have the code as a submodule, but defined inside the extension.

[core-ai-bot]

Comment by DennisKehrig
Saturday Mar 23, 2013 at 10:43 GMT

---

This only works for extensions with an own repository, though, so I think you did it exactly right. Especially since many other third party modules like jQuery are just copies, too.

[core-ai-bot]

Comment by TomMalbran
Saturday Mar 23, 2013 at 22:17 GMT

---

Fixed the review comments and merged with master.

The main issue I was thinking of when using submodules in an extension is what would happen if the folder doesn't exists, when the extension isn't there. But since is a default extension and removing it would mean to remove it from the repository, it would be needed to remove the submodule too. So I think that re-adding JSLint as a submodule can be good, if you think is needed/better.

[core-ai-bot]

Comment by DennisKehrig
Thursday Mar 28, 2013 at 18:28 GMT

---

Alright, merging!