Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Color Editor CSS cleanups #2136

Open
core-ai-bot opened this issue Aug 29, 2021 · 3 comments
Open

[CLOSED] Color Editor CSS cleanups #2136

core-ai-bot opened this issue Aug 29, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by ZweiSteinSoft
Tuesday Nov 27, 2012 at 16:34 GMT
Originally opened as adobe/brackets#2225

Fix for #2216.

ZweiSteinSoft included the following code: https://github.com/adobe/brackets/pull/2225/commits
@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Tuesday Nov 27, 2012 at 23:29 GMT

Nice work! You did exactly what@peterflynn said in #2216. I only found one instance that you missed in converting _ to -.

We're closing down for Sprint 17 and your pull request just missed our pencil-downs yesterday. Also, you may need to redo part of your work with the latest code as@peterflynn had a major clean up in ColorEditor.js.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Wednesday Nov 28, 2012 at 19:26 GMT

Great! ready to merge but we have to wait until sprint 17 close.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Saturday Dec 08, 2012 at 04:01 GMT

Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot