[CLOSED] Line Comment should delegate to Block Comment in block-only languages like CSS

[core-ai-bot]

Issue by peterflynn
Thursday Nov 15, 2012 at 01:57 GMT
Originally opened as adobe/brackets#2119

---

1. Open a CSS file
2. Press Ctrl+/

Result: nothing happens

Expected: fall back to block comments when line comments are unavailable

There's a twist, though: in some editors (like Sublime), the block comment behavior is subtly different when invoked as a fallback like this. When there's no selection, the entire line is wrapped in a block comment (the normal behavior, and what you get if you invoke block comment explicitly, is to insert an empty block comment at the cursor position).

[core-ai-bot]

Comment by TomMalbran
Thursday Nov 15, 2012 at 06:45 GMT

---

This is what i was planning to implement next, but wasn't sure if it should just make a block comment over the selection, or over all the lines in the selection. Maybe this second approach might work better on HTML, where commenting a block over several lines that don't include the complete lines is not usual.

In any case, it should be easy enough, by adding an additional parameter to block-comment with the positions for the prefix and suffix in the case of a block-comment.

[core-ai-bot]

Comment by pthiess
Thursday Nov 15, 2012 at 17:53 GMT

---

This is a very nice ECR, I assign@peterflynn just because we can't assign to Tom directly.

[core-ai-bot]

Comment by peterflynn
Friday Dec 14, 2012 at 03:05 GMT

---

This is solid! I wrote some unit tests to cover this too, which I'll put up a pull request for as soon as #2342 is ironed out.