[CLOSED] Refactor SVG files

[core-ai-bot]

Issue by DmitryBaranovskiy
Monday Aug 27, 2012 at 07:21 GMT
Originally opened as adobe/brackets#1453

---

I wonder, is there any performance reason to not use SVG filters for shadows?

---

DmitryBaranovskiy included the following code: https://github.com/adobe/brackets/pull/1453/commits

[core-ai-bot]

Comment by GarthDB
Monday Aug 27, 2012 at 11:10 GMT

---

No performance reasons, but I could not get the filters to render correctly in hidpi resolutions. I'll try out your assets on the retina MacBook and see how they look.

[core-ai-bot]

Comment by GarthDB
Monday Aug 27, 2012 at 18:57 GMT

---

Looks good. I thought from the comment you had switched to filters, but it still uses the pseudo shadows, so it has no effect on hidpi.

Thanks for the clean up.

[core-ai-bot]

Comment by DmitryBaranovskiy
Tuesday Aug 28, 2012 at 04:55 GMT

---

I wanted to switch to filters, but I was thinking there are some reason for not to use them. I will send another pull request with filters ;)