Live HTML highlighting is often in the wrong place with Reveal.js

[core-ai-bot]

Issue by dangoor
Friday Sep 13, 2013 at 11:10 GMT
Originally opened as adobe/brackets#5192

---

If you're working on a Reveal.js presentation, the live highlight is often in the wrong place (even when the cursor is in an element that is visible on the screen). It may be the case that there's no easy solution to this because of the way that Reveal.js does its layout, but I thought I'd open this for comment from the people who know the live highlighting better than I do.

[core-ai-bot]

Comment by njx
Monday Sep 16, 2013 at 18:43 GMT

---

Reviewed. Medium priority to me to see if this is a more general problem.

[core-ai-bot]

Comment by njx
Saturday Jul 12, 2014 at 03:24 GMT

---

To@dangoor

[core-ai-bot]

Comment by redmunds
Wednesday Oct 15, 2014 at 01:18 GMT

---

This may be fixed by adobe/brackets#8922 by@MarcelGerber. I tested a reveal presentation that I made for Sprint 30 Review -- it renders correctly in this branch, but also in master.

@dangoor Do you have the original reveal presentation that you can test against that PR?

[core-ai-bot]

Comment by redmunds
Wednesday Oct 15, 2014 at 20:48 GMT

---

FBNC back to@dangoor .

[core-ai-bot]

Comment by dangoor
Wednesday Oct 22, 2014 at 15:12 GMT

---

I just took a look at this. It is not fixed on current master (103e67db945e7cf2f53eebfb5e3ac3b4d110d355). I think this is likely a problem with the way Reveal does positioning rather than a more general problem, so I'm reducing this to low priority.

[core-ai-bot]

Comment by MarcelGerber
Wednesday Oct 22, 2014 at 15:17 GMT

---

@dangoor Could you upload a little Reveal presentation for me to take a look at that issue?

[core-ai-bot]

Comment by redmunds
Wednesday Oct 22, 2014 at 15:26 GMT

---

@dangoor Note that highlighting of elements only on the current "page" of a Reveal presentation are expected to be correct. If that's the case, can you post the presentation for us to look at?

[core-ai-bot]

Comment by dangoor
Wednesday Oct 22, 2014 at 18:00 GMT

---

I've uploaded the presentation. Just start live preview on index.html there.

[core-ai-bot]

Comment by redmunds
Wednesday Oct 22, 2014 at 18:14 GMT

---

I didn't exhaustively test every page and element, but this looks to me. Can you provide a recipe for which page you are viewing in browser and which elements you are selecting in Brackets that have highlights out of place?

[core-ai-bot]

Comment by MarcelGerber
Wednesday Oct 22, 2014 at 19:42 GMT

---

I see the issue.
For the best effect, it's probably best to find some way to simplify jQuery's position as much as we can and use it there. That's basically what I did, but I oversimplified it (on purpose, I didn't want 100 lines hanging around).